third_party/WebKit/LayoutTests/http/tests/wasm/wasm_local_iframe_test.html - Issue 2749503002: [wasm] enable wasm structured cloning in specific cases

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/wasm/wasm_local_iframe_test.html

Issue 2749503002: [wasm] enable wasm structured cloning in specific cases (Closed)

Patch Set: fixed idb test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js ('K') | « third_party/WebKit/LayoutTests/http/tests/wasm/wasm_indexeddb_test.js ('k') | third_party/WebKit/LayoutTests/http/tests/wasm/wasm_serialization_tests.js » ('j') | third_party/WebKit/LayoutTests/http/tests/wasm/wasm_service_worker_test.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <script src="resources/load_wasm.js"></script>

	5 <iframe src="resources/frame.html" id="iframe"></iframe>

	6 <script>

	7 function TestSendToIFrame() {
	jbroman 2017/03/27 18:50:52 As a matter of style, some of these console.log ca As a matter of style, some of these console.log can probably be removed, as they're implied by the test results. It's also implied that a promise failure fails the test, so assert_unreached for that is unnecessary. Finally, the control flow is slightly easier to read with async functions, but I don't feel as strongly about that: promise_test(async function() { var mod = await createWasmModule(); assert_true(mod instanceof WebAssembly.Module); var ans = await new Promise((resolve, reject) => { var iframe = document.getElementById("iframe").contentWindow; iframe.postMessage(mod, ''); iframe.onmessage = event => resolve(event.data); }); assert_equals(ans, 43); }, "send wasm module to iframe"); Mircea Trofin* 2017/03/27 20:52:32 The console were there for my debugging, thanks fo Show quoted text On 2017/03/27 18:50:52, jbroman wrote: > As a matter of style, some of these console.log can probably be removed, as > they're implied by the test results. It's also implied that a promise failure > fails the test, so assert_unreached for that is unnecessary. > > Finally, the control flow is slightly easier to read with async functions, but I > don't feel as strongly about that: > > promise_test(async function() { > var mod = await createWasmModule(); > assert_true(mod instanceof WebAssembly.Module); > var ans = await new Promise((resolve, reject) => { > var iframe = document.getElementById("iframe").contentWindow; > iframe.postMessage(mod, ''); > iframe.onmessage = event => resolve(event.data); > }); > assert_equals(ans, 43); > }, "send wasm module to iframe"); The console were there for my debugging, thanks for catching. I thought "Promises" were more "modern, the way forward", hence the sticking with that pattern. jbroman* 2017/03/28 15:27:25 async/await is the more recent (ES 2017) syntactic Show quoted text On 2017/03/27 at 20:52:32, Mircea Trofin wrote: > On 2017/03/27 18:50:52, jbroman wrote: > > As a matter of style, some of these console.log can probably be removed, as > > they're implied by the test results. It's also implied that a promise failure > > fails the test, so assert_unreached for that is unnecessary. > > > > Finally, the control flow is slightly easier to read with async functions, but I > > don't feel as strongly about that: > > > > promise_test(async function() { > > var mod = await createWasmModule(); > > assert_true(mod instanceof WebAssembly.Module); > > var ans = await new Promise((resolve, reject) => { > > var iframe = document.getElementById("iframe").contentWindow; > > iframe.postMessage(mod, '*'); > > iframe.onmessage = event => resolve(event.data); > > }); > > assert_equals(ans, 43); > > }, "send wasm module to iframe"); > > The console were there for my debugging, thanks for catching. > > I thought "Promises" were more "modern, the way forward", hence the sticking with that pattern. async/await is the more recent (ES 2017) syntactic sugar for promises. "await" causes the function to close over its scope and resume execution when the promise is resolved (using \|then\| implicitly). You don't have to use it, but to me it makes the code easier to read while still using (and hence having the advantages of) promises.
	8 var iframe = document.getElementById("iframe").contentWindow;

	9 return createWasmModule()

	10 .then(mod => {

	11 console.log(mod instanceof WebAssembly.Module);

	12 console.log("created module");

	13 return new Promise((resolve, reject) => {

	14 console.log("posted module");

	15 iframe.postMessage(mod, "*");

	16 iframe.onmessage = function(event) {

	17 console.log("got reply");

	18 resolve(event.data);

	19 }

	20 });

	21 })

	22 .then(ans => assert_equals(ans, 43))

	23 .catch(assert_unreached);

	24 }

	25 promise_test(TestSendToIFrame, "send wasm module to worker");
	jbroman 2017/03/27 18:50:52 to iframe, not worker, right? to iframe, not worker, right? Mircea Trofin 2017/03/27 20:52:33 Done. Show quoted text On 2017/03/27 18:50:52, jbroman wrote: > to iframe, not worker, right? Done.
	26 </script>

OLD	NEW