content/shell/browser/layout_test/layout_test_notification_manager.h - Issue 2749453002: Make GetDisplayedNotifications asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.h

Issue 2749453002: Make GetDisplayedNotifications asynchronous. (Closed)

Patch Set: review Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/platform_notification_service.h ('k') | content/shell/browser/layout_test/layout_test_notification_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_notification_manager.h

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.h b/content/shell/browser/layout_test/layout_test_notification_manager.h

index 25ce88f2cef5425a6c0f57cc5a93cef463dd5e32..184b13e2bd437fd321a2ff8cf6fbc2f92d041c4a 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.h

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.h

@@ -71,9 +71,9 @@ class LayoutTestNotificationManager : public PlatformNotificationService {

const NotificationResources& notification_resources) override;

void ClosePersistentNotification(BrowserContext* browser_context,

const std::string& notification_id) override;

- bool GetDisplayedNotifications(

+ void GetDisplayedNotifications(

BrowserContext* browser_context,

- std::set<std::string>* displayed_notifications) override;

+ const DisplayedNotificationsCallback& callback) override;

private:

// Structure to represent the information of a persistent notification.