Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: chrome/browser/notifications/native_notification_display_service.cc

Issue 2749453002: Make GetDisplayedNotifications asynchronous. (Closed)
Patch Set: review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/native_notification_display_service.cc
diff --git a/chrome/browser/notifications/native_notification_display_service.cc b/chrome/browser/notifications/native_notification_display_service.cc
index 2de879d0bee177fe377d7bfd028db38317b7c310..169f175e63e107d74a8bbbab0c7810a57b4dde50 100644
--- a/chrome/browser/notifications/native_notification_display_service.cc
+++ b/chrome/browser/notifications/native_notification_display_service.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/notifications/notification_platform_bridge.h"
#include "chrome/browser/notifications/persistent_notification_handler.h"
#include "chrome/browser/profiles/profile.h"
+#include "content/public/browser/browser_thread.h"
namespace {
@@ -69,10 +70,10 @@ void NativeNotificationDisplayService::Close(
handler->OnClose(profile_, "", notification_id, false /* by user */);
}
-bool NativeNotificationDisplayService::GetDisplayed(
- std::set<std::string>* notifications) const {
+void NativeNotificationDisplayService::GetDisplayed(
+ const DisplayedNotificationsCallback& callback) const {
return notification_bridge_->GetDisplayed(
- GetProfileId(profile_), profile_->IsOffTheRecord(), notifications);
+ GetProfileId(profile_), profile_->IsOffTheRecord(), callback);
}
void NativeNotificationDisplayService::ProcessNotificationOperation(

Powered by Google App Engine
This is Rietveld 408576698