chrome/browser/notifications/notification_platform_bridge_android.h - Issue 2749453002: Make GetDisplayedNotifications asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.h

Issue 2749453002: Make GetDisplayedNotifications asynchronous. (Closed)

Patch Set: revert early bailout if there is no service Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_display_service.h ('K') | « chrome/browser/notifications/notification_platform_bridge.h ('k') | chrome/browser/notifications/notification_platform_bridge_android.cc » ('j') | chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_android.h

diff --git a/chrome/browser/notifications/notification_platform_bridge_android.h b/chrome/browser/notifications/notification_platform_bridge_android.h

index 301338deb0aac23e44f09d31f81aff8e6c1ba547..2223881cb37b32086ad757d53b2a72ab288088a4 100644

--- a/chrome/browser/notifications/notification_platform_bridge_android.h

+++ b/chrome/browser/notifications/notification_platform_bridge_android.h

@@ -69,9 +69,10 @@ class NotificationPlatformBridgeAndroid : public NotificationPlatformBridge {

const Notification& notification) override;

void Close(const std::string& profile_id,

const std::string& notification_id) override;

- bool GetDisplayed(const std::string& profile_id,

- bool incognito,

- std::set<std::string>* notifications) const override;

+ void GetDisplayed(

+ const std::string& profile_id,

+ bool incognito,

+ const DisplayedNotificationsCallback& callback) const override;

static bool RegisterNotificationPlatformBridge(JNIEnv* env);