Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: content/test/mock_platform_notification_service.h

Issue 2749453002: Make GetDisplayedNotifications asynchronous. (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/mock_platform_notification_service.h
diff --git a/content/test/mock_platform_notification_service.h b/content/test/mock_platform_notification_service.h
index 790053badd1bb331feedb20ccc4bc867f1b0a76e..5f3de7cffc3671d892f3ae5ca5254971ea554fca 100644
--- a/content/test/mock_platform_notification_service.h
+++ b/content/test/mock_platform_notification_service.h
@@ -71,9 +71,10 @@ class MockPlatformNotificationService : public PlatformNotificationService {
const NotificationResources& notification_resources) override;
void ClosePersistentNotification(BrowserContext* browser_context,
const std::string& notification_id) override;
- bool GetDisplayedNotifications(
+ void GetDisplayedNotifications(
BrowserContext* browser_context,
- std::set<std::string>* displayed_notifications) override;
+ const base::Callback<void(std::unique_ptr<std::set<std::string>>,
+ bool /* success */)>& callback) override;
Peter Beverloo 2017/03/15 18:07:51 Why doesn't this use the typedef?
Miguel Garcia 2017/03/16 14:57:43 Done.
protected:
// Checks if |origin| has permission to display notifications. May be called

Powered by Google App Engine
This is Rietveld 408576698