Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/notifications/stub_notification_platform_bridge.h

Issue 2749453002: Make GetDisplayedNotifications asynchronous. (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/stub_notification_platform_bridge.h
diff --git a/chrome/browser/notifications/stub_notification_platform_bridge.h b/chrome/browser/notifications/stub_notification_platform_bridge.h
index 2e3f45a7045a1fd7d5e54247b19703530cb653de..25dc4bb2a5a95b7bd1a95ff3370d2236015c3809 100644
--- a/chrome/browser/notifications/stub_notification_platform_bridge.h
+++ b/chrome/browser/notifications/stub_notification_platform_bridge.h
@@ -22,6 +22,9 @@ class StubNotificationPlatformBridge : public NotificationPlatformBridge {
// Returns the notification being displayed at position |index|.
Notification GetNotificationAt(std::string profile_id, size_t index);
+ // Returns the number of notifications displayed.
+ size_t GetNotificationCount();
Peter Beverloo 2017/03/15 18:07:51 This kind of feels like cheating :P
Miguel Garcia 2017/03/16 14:57:42 well it's a test :)
+
// NotificationPlatformBridge implementation.
void Display(NotificationCommon::Type notification_type,
const std::string& notification_id,
@@ -30,9 +33,9 @@ class StubNotificationPlatformBridge : public NotificationPlatformBridge {
const Notification& notification) override;
void Close(const std::string& profile_id,
const std::string& notification_id) override;
- bool GetDisplayed(const std::string& profile_id,
+ void GetDisplayed(const std::string& profile_id,
bool incognito,
- std::set<std::string>* notifications) const override;
+ const NotificationResultCallback& callback) const override;
private:
// Map of profile Ids to list of notifications shown for said profile.

Powered by Google App Engine
This is Rietveld 408576698