Make GetDisplayedNotifications asynchronous.

chrome/browser/notifications/message_center_display_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_display_service.h"
 
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/profiles/profile.h"
+#include "content/public/browser/browser_thread.h"
 
 MessageCenterDisplayService::MessageCenterDisplayService(
     Profile* profile,
     NotificationUIManager* ui_manager)
     : profile_(profile), ui_manager_(ui_manager) {}
 
 MessageCenterDisplayService::~MessageCenterDisplayService() {}
 
 void MessageCenterDisplayService::Display(
     NotificationCommon::Type notification_type,
     const std::string& notification_id,
     const Notification& notification) {
   // TODO(miguelg): MCDS should stop relying on the |notification|'s delegate
   // for Close/Click operations once the Notification object becomes a mojom
   // type.
   ui_manager_->Add(notification, profile_);
 }
 
 void MessageCenterDisplayService::Close(
     NotificationCommon::Type notification_type,
     const std::string& notification_id) {
   ui_manager_->CancelById(notification_id,
                           NotificationUIManager::GetProfileID(profile_));
 }
 
-bool MessageCenterDisplayService::GetDisplayed(
-    std::set<std::string>* notifications) const {
-  DCHECK(notifications);
+void MessageCenterDisplayService::GetDisplayed(
+    const DisplayedNotificationsCallback& callback) const {
+  auto displayed_notifications = base::MakeUnique<std::set<std::string>>();
   for (auto notification_id : ui_manager_->GetAllIdsByProfile(
            NotificationUIManager::GetProfileID(profile_))) {
-    notifications->insert(notification_id);
+    displayed_notifications->insert(notification_id);
   }

[Peter Beverloo, 2017/03/17 15:46:04]

Sorry that I missed this before -- GetAllIdsByProfile returns an std::set() with
the notification IDs. Why not do:

auto displayed_notifications =
    base::MakeUnique<std::set>(
        std::move(ui_manager_->GetAllIdsByProfile(
            NotificationUIManager::GetProfileID(profile_))));

That eliminates all copies :).

[Miguel Garcia, 2017/03/20 14:11:20]

Done.

-  return true;
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(callback, base::Passed(&displayed_notifications),
+                 true /* supports sync */));
 }