Make GetDisplayedNotifications asynchronous.

content/shell/browser/layout_test/layout_test_notification_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/layout_test/layout_test_notification_manager.h"
 
 #include "base/guid.h"
 #include "base/strings/nullable_string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 65 matching lines @@
 }
 
 void LayoutTestNotificationManager::ClosePersistentNotification(
     BrowserContext* browser_context,
     const std::string& notification_id) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   persistent_notifications_.erase(notification_id);
 }
 
-bool LayoutTestNotificationManager::GetDisplayedNotifications(
+void LayoutTestNotificationManager::GetDisplayedNotifications(
     BrowserContext* browser_context,
-    std::set<std::string>* displayed_notifications) {
-  DCHECK_CURRENTLY_ON(BrowserThread::UI);
-  DCHECK(displayed_notifications);
-
-  // Notifications will never outlive the lifetime of running layout tests.
-  return false;
+    const NotificationResultCallback& callback) {
+  std::unique_ptr<std::set<std::string>> displayedNotifications =

[Peter Beverloo, 2017/03/15 18:07:51]

nit: displayed_notifications

[Miguel Garcia, 2017/03/16 14:57:43]

Done.

+      base::MakeUnique<std::set<std::string>>();
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,

[Peter Beverloo, 2017/03/15 18:07:51]

nit: drop content:: from these, you are in that namespace

[Miguel Garcia, 2017/03/16 14:57:42]

Done.

+      base::Bind(callback, base::Passed(&displayedNotifications),
+                 false /* supports getting displayed notifications */));
 }
 
 void LayoutTestNotificationManager::SimulateClick(
     const std::string& title,
     int action_index,
     const base::NullableString16& reply) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   const auto notification_id_iter = notification_id_map_.find(title);
   if (notification_id_iter == notification_id_map_.end())
@@ skipping 88 matching lines @@
 LayoutTestNotificationManager::CheckPermission(const GURL& origin) {
   return LayoutTestContentBrowserClient::Get()
       ->GetLayoutTestBrowserContext()
       ->GetLayoutTestPermissionManager()
       ->GetPermissionStatus(PermissionType::NOTIFICATIONS,
                             origin,
                             origin);
 }
 
 }  // namespace content