Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 274943002: [refactor] Move giant JWK import comment block to top of file. (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[refactor] Move giant JWK import comment block to top of file. BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269495

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove comment that is no longer applicable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -163 lines) Patch
M content/child/webcrypto/jwk.cc View 1 2 chunks +154 lines, -163 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
eroman
6 years, 7 months ago (2014-05-08 23:39:22 UTC) #1
eroman
(also low priority pedantry)
6 years, 7 months ago (2014-05-08 23:39:33 UTC) #2
Ryan Sleevi
lgtm https://codereview.chromium.org/274943002/diff/1/content/child/webcrypto/jwk.cc File content/child/webcrypto/jwk.cc (right): https://codereview.chromium.org/274943002/diff/1/content/child/webcrypto/jwk.cc#newcode41 content/child/webcrypto/jwk.cc:41: // value (if present) is used as a ...
6 years, 7 months ago (2014-05-08 23:41:25 UTC) #3
eroman
https://codereview.chromium.org/274943002/diff/1/content/child/webcrypto/jwk.cc File content/child/webcrypto/jwk.cc (right): https://codereview.chromium.org/274943002/diff/1/content/child/webcrypto/jwk.cc#newcode41 content/child/webcrypto/jwk.cc:41: // value (if present) is used as a fallback. ...
6 years, 7 months ago (2014-05-08 23:43:26 UTC) #4
Ryan Sleevi
Fix it here is fine
6 years, 7 months ago (2014-05-08 23:44:27 UTC) #5
eroman
Done
6 years, 7 months ago (2014-05-09 00:39:35 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-09 00:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/274943002/20001
6 years, 7 months ago (2014-05-09 00:57:28 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 04:33:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 06:22:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/14116)
6 years, 7 months ago (2014-05-09 06:22:07 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-09 15:49:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/274943002/20001
6 years, 7 months ago (2014-05-09 15:53:36 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 02:47:03 UTC) #14
Message was sent while issue was closed. 
Change committed as 269495

Powered by Google App Engine
This is Rietveld 408576698