Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2749423002: [Devtools] Renamed _loadColumns and _saveColumns to be more appropriate (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index 960b93b9f9d598dee4c3ed6873eaafdae43f1b0b..2001eb2936f9424d3b3c932ba5effabb8408f2c6 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -86,7 +86,7 @@ Network.NetworkLogViewColumns = class {
columnConfig.titleDOMFragment = this._makeHeaderFragment(columnConfig.title, columnConfig.subtitle);
this._columns.push(columnConfig);
}
- this._loadColumns();
+ this._loadCustomColumnsAndSettings();
this._popoverHelper = new UI.PopoverHelper(this._networkLogView.element);
this._popoverHelper.initializeCallbacks(
@@ -330,13 +330,13 @@ Network.NetworkLogViewColumns = class {
* @param {!Network.NetworkLogViewColumns.Descriptor} columnConfig
*/
_toggleColumnVisibility(columnConfig) {
- this._loadColumns();
+ this._loadCustomColumnsAndSettings();
columnConfig.visible = !columnConfig.visible;
- this._saveColumns();
+ this._saveColumnsSettings();
this._updateColumns();
}
- _saveColumns() {
+ _saveColumnsSettings() {
var saveableSettings = {};
for (var columnConfig of this._columns)
saveableSettings[columnConfig.id] = {visible: columnConfig.visible, title: columnConfig.title};
@@ -344,7 +344,7 @@ Network.NetworkLogViewColumns = class {
this._persistantSettings.set(saveableSettings);
}
- _loadColumns() {
+ _loadCustomColumnsAndSettings() {
var savedSettings = this._persistantSettings.get();
var columnIds = Object.keys(savedSettings);
for (var columnId of columnIds) {
@@ -461,7 +461,7 @@ Network.NetworkLogViewColumns = class {
return false;
this._columns.splice(index, 1);
this._dataGrid.removeColumn(headerId);
- this._saveColumns();
+ this._saveColumnsSettings();
this._updateColumns();
return true;
}
@@ -494,7 +494,7 @@ Network.NetworkLogViewColumns = class {
this._columns.splice(index, 0, columnConfig);
if (this._dataGrid)
this._dataGrid.addColumn(Network.NetworkLogViewColumns._convertToDataGridDescriptor(columnConfig), index);
- this._saveColumns();
+ this._saveColumnsSettings();
this._updateColumns();
return columnConfig;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698