Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2749403004: Update subtree paint properties when preserve-3d changes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 1914 matching lines...) Expand 10 before | Expand all | Expand 10 after
1925 1925
1926 if (diff.needsFullPaintInvalidation() && oldStyle) { 1926 if (diff.needsFullPaintInvalidation() && oldStyle) {
1927 if (resolveColor(*oldStyle, CSSPropertyBackgroundColor) != 1927 if (resolveColor(*oldStyle, CSSPropertyBackgroundColor) !=
1928 resolveColor(CSSPropertyBackgroundColor) || 1928 resolveColor(CSSPropertyBackgroundColor) ||
1929 oldStyle->backgroundLayers() != styleRef().backgroundLayers()) 1929 oldStyle->backgroundLayers() != styleRef().backgroundLayers())
1930 setBackgroundChangedSinceLastPaintInvalidation(); 1930 setBackgroundChangedSinceLastPaintInvalidation();
1931 } 1931 }
1932 1932
1933 if (oldStyle && oldStyle->styleType() == PseudoIdNone) 1933 if (oldStyle && oldStyle->styleType() == PseudoIdNone)
1934 applyPseudoStyleChanges(*oldStyle); 1934 applyPseudoStyleChanges(*oldStyle);
1935
1936 if (RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() && oldStyle &&
1937 oldStyle->usedTransformStyle3D() != styleRef().usedTransformStyle3D()) {
1938 // Change of transform-style may affect descendant transform property nodes.
1939 setSubtreeNeedsPaintPropertyUpdate();
1940 }
1935 } 1941 }
1936 1942
1937 void LayoutObject::applyPseudoStyleChanges(const ComputedStyle& oldStyle) { 1943 void LayoutObject::applyPseudoStyleChanges(const ComputedStyle& oldStyle) {
1938 if (oldStyle.hasPseudoStyle(PseudoIdFirstLine) || 1944 if (oldStyle.hasPseudoStyle(PseudoIdFirstLine) ||
1939 styleRef().hasPseudoStyle(PseudoIdFirstLine)) 1945 styleRef().hasPseudoStyle(PseudoIdFirstLine))
1940 applyFirstLineChanges(oldStyle); 1946 applyFirstLineChanges(oldStyle);
1941 1947
1942 if (oldStyle.hasPseudoStyle(PseudoIdSelection) || 1948 if (oldStyle.hasPseudoStyle(PseudoIdSelection) ||
1943 styleRef().hasPseudoStyle(PseudoIdSelection)) 1949 styleRef().hasPseudoStyle(PseudoIdSelection))
1944 invalidatePaintForSelection(); 1950 invalidatePaintForSelection();
(...skipping 1653 matching lines...) Expand 10 before | Expand all | Expand 10 after
3598 const blink::LayoutObject* root = object1; 3604 const blink::LayoutObject* root = object1;
3599 while (root->parent()) 3605 while (root->parent())
3600 root = root->parent(); 3606 root = root->parent();
3601 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3607 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3602 } else { 3608 } else {
3603 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3609 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3604 } 3610 }
3605 } 3611 }
3606 3612
3607 #endif 3613 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698