third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2749383005: [Devtools] Add stacktrace for Page.frameAttached event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2749383005: [Devtools] Add stacktrace for Page.frameAttached event (Closed)

Patch Set: added test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/page/frameAttachedStacktrace.html ('K') | « third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index 6527abc46147dfce17a799ed161709ebaff09425..3038fd2a23e12e2871d77e2b9be187de0e0635dd 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -544,7 +544,8 @@

"description": "Fired when frame has been attached to its parent.",

"parameters": [

{ "name": "frameId", "$ref": "FrameId", "description": "Id of the frame that has been attached." },

- { "name": "parentFrameId", "$ref": "FrameId", "description": "Parent frame identifier." }

+ { "name": "parentFrameId", "$ref": "FrameId", "description": "Parent frame identifier." },

+ { "name": "stack", "$ref": "Runtime.StackTrace", "optional": true, "description": "JavaScript stack trace of when frame was attached, set for Script only.", "experimental": true }

dgozman 2017/03/20 17:53:37 What is "set for Script only"?

allada 2017/03/21 00:19:20 I meant "only available if came from script", ie:

]

{