Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc

Issue 2749383003: WorkerThread CPU Load UMA (Closed)
Patch Set: histogram comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/child/worker_scheduler_impl.h" 5 #include "platform/scheduler/child/worker_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/metrics/histogram_macros.h" 8 #include "base/metrics/histogram_macros.h"
9 #include "base/trace_event/trace_event.h" 9 #include "base/trace_event/trace_event.h"
10 #include "base/trace_event/trace_event_argument.h" 10 #include "base/trace_event/trace_event_argument.h"
11 #include "platform/scheduler/base/time_converter.h"
11 #include "platform/scheduler/child/scheduler_tqm_delegate.h" 12 #include "platform/scheduler/child/scheduler_tqm_delegate.h"
12 #include "public/platform/scheduler/base/task_queue.h" 13 #include "public/platform/scheduler/base/task_queue.h"
13 14
14 namespace blink { 15 namespace blink {
15 namespace scheduler { 16 namespace scheduler {
16 17
18 namespace {
19 // Workers could be short-lived, set a shorter interval than
20 // the renderer thread.
21 constexpr base::TimeDelta kWorkerThreadLoadTrackerReportingInterval =
22 base::TimeDelta::FromSeconds(1);
23 // Start reporting the load right away.
24 constexpr base::TimeDelta kWorkerThreadLoadTrackerWaitingPeriodBeforeReporting =
25 base::TimeDelta::FromSeconds(0);
26
27 void ReportWorkerTaskLoad(base::TimeTicks time, double load) {
28 int load_percentage = static_cast<int>(load * 100);
29 DCHECK_LE(load_percentage, 100);
30 // TODO(kinuko): Maybe we also want to separately log when the associated
31 // tab is in foreground and when not.
32 UMA_HISTOGRAM_PERCENTAGE("WorkerScheduler.WorkerThreadLoad", load_percentage);
33 }
34
35 } // namespace
36
17 WorkerSchedulerImpl::WorkerSchedulerImpl( 37 WorkerSchedulerImpl::WorkerSchedulerImpl(
18 scoped_refptr<SchedulerTqmDelegate> main_task_runner) 38 scoped_refptr<SchedulerTqmDelegate> main_task_runner)
19 : helper_(main_task_runner, 39 : helper_(main_task_runner,
20 "worker.scheduler", 40 "worker.scheduler",
21 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), 41 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"),
22 TRACE_DISABLED_BY_DEFAULT("worker.scheduler.debug")), 42 TRACE_DISABLED_BY_DEFAULT("worker.scheduler.debug")),
23 idle_helper_(&helper_, 43 idle_helper_(&helper_,
24 this, 44 this,
25 "worker.scheduler", 45 "worker.scheduler",
26 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), 46 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"),
27 "WorkerSchedulerIdlePeriod", 47 "WorkerSchedulerIdlePeriod",
28 base::TimeDelta::FromMilliseconds(300)), 48 base::TimeDelta::FromMilliseconds(300)),
29 idle_canceled_delayed_task_sweeper_("worker.scheduler", 49 idle_canceled_delayed_task_sweeper_("worker.scheduler",
30 &helper_, 50 &helper_,
31 idle_helper_.IdleTaskRunner()) { 51 idle_helper_.IdleTaskRunner()),
52 load_tracker_(helper_.scheduler_tqm_delegate()->NowTicks(),
53 base::Bind(&ReportWorkerTaskLoad),
54 kWorkerThreadLoadTrackerReportingInterval,
55 kWorkerThreadLoadTrackerWaitingPeriodBeforeReporting) {
32 initialized_ = false; 56 initialized_ = false;
33 thread_start_time_ = helper_.scheduler_tqm_delegate()->NowTicks(); 57 thread_start_time_ = helper_.scheduler_tqm_delegate()->NowTicks();
58 load_tracker_.Resume(thread_start_time_);
59 helper_.AddTaskTimeObserver(this);
34 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 60 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
35 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), "WorkerScheduler", this); 61 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), "WorkerScheduler", this);
36 } 62 }
37 63
38 WorkerSchedulerImpl::~WorkerSchedulerImpl() { 64 WorkerSchedulerImpl::~WorkerSchedulerImpl() {
39 TRACE_EVENT_OBJECT_DELETED_WITH_ID( 65 TRACE_EVENT_OBJECT_DELETED_WITH_ID(
40 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), "WorkerScheduler", this); 66 TRACE_DISABLED_BY_DEFAULT("worker.scheduler"), "WorkerScheduler", this);
67 helper_.RemoveTaskTimeObserver(this);
41 } 68 }
42 69
43 void WorkerSchedulerImpl::Init() { 70 void WorkerSchedulerImpl::Init() {
44 initialized_ = true; 71 initialized_ = true;
45 idle_helper_.EnableLongIdlePeriod(); 72 idle_helper_.EnableLongIdlePeriod();
46 } 73 }
47 74
48 scoped_refptr<TaskQueue> WorkerSchedulerImpl::DefaultTaskRunner() { 75 scoped_refptr<TaskQueue> WorkerSchedulerImpl::DefaultTaskRunner() {
49 DCHECK(initialized_); 76 DCHECK(initialized_);
50 return helper_.DefaultTaskRunner(); 77 return helper_.DefaultTaskRunner();
(...skipping 21 matching lines...) Expand all
72 helper_.AddTaskObserver(task_observer); 99 helper_.AddTaskObserver(task_observer);
73 } 100 }
74 101
75 void WorkerSchedulerImpl::RemoveTaskObserver( 102 void WorkerSchedulerImpl::RemoveTaskObserver(
76 base::MessageLoop::TaskObserver* task_observer) { 103 base::MessageLoop::TaskObserver* task_observer) {
77 DCHECK(initialized_); 104 DCHECK(initialized_);
78 helper_.RemoveTaskObserver(task_observer); 105 helper_.RemoveTaskObserver(task_observer);
79 } 106 }
80 107
81 void WorkerSchedulerImpl::Shutdown() { 108 void WorkerSchedulerImpl::Shutdown() {
109 load_tracker_.RecordIdle(helper_.scheduler_tqm_delegate()->NowTicks());
82 DCHECK(initialized_); 110 DCHECK(initialized_);
Sami 2017/04/03 13:56:22 nit: Please keep the DCHECK first.
kinuko 2017/04/03 23:23:47 Done.
83 base::TimeTicks end_time = helper_.scheduler_tqm_delegate()->NowTicks(); 111 base::TimeTicks end_time = helper_.scheduler_tqm_delegate()->NowTicks();
84 base::TimeDelta delta = end_time - thread_start_time_; 112 base::TimeDelta delta = end_time - thread_start_time_;
85 113
86 // The lifetime could be radically different for different workers, 114 // The lifetime could be radically different for different workers,
87 // some workers could be short-lived (but last at least 1 sec in 115 // some workers could be short-lived (but last at least 1 sec in
88 // Service Workers case) or could be around as long as the tab is open. 116 // Service Workers case) or could be around as long as the tab is open.
89 UMA_HISTOGRAM_CUSTOM_TIMES( 117 UMA_HISTOGRAM_CUSTOM_TIMES(
90 "WorkerThread.Runtime", delta, base::TimeDelta::FromSeconds(1), 118 "WorkerThread.Runtime", delta, base::TimeDelta::FromSeconds(1),
91 base::TimeDelta::FromDays(1), 50 /* bucket count */); 119 base::TimeDelta::FromDays(1), 50 /* bucket count */);
92 helper_.Shutdown(); 120 helper_.Shutdown();
93 } 121 }
94 122
95 SchedulerHelper* WorkerSchedulerImpl::GetSchedulerHelperForTesting() { 123 SchedulerHelper* WorkerSchedulerImpl::GetSchedulerHelperForTesting() {
96 return &helper_; 124 return &helper_;
97 } 125 }
98 126
99 bool WorkerSchedulerImpl::CanEnterLongIdlePeriod(base::TimeTicks, 127 bool WorkerSchedulerImpl::CanEnterLongIdlePeriod(base::TimeTicks,
100 base::TimeDelta*) { 128 base::TimeDelta*) {
101 return true; 129 return true;
102 } 130 }
103 131
104 base::TimeTicks WorkerSchedulerImpl::CurrentIdleTaskDeadlineForTesting() const { 132 base::TimeTicks WorkerSchedulerImpl::CurrentIdleTaskDeadlineForTesting() const {
105 return idle_helper_.CurrentIdleTaskDeadline(); 133 return idle_helper_.CurrentIdleTaskDeadline();
106 } 134 }
107 135
136 void WorkerSchedulerImpl::willProcessTask(TaskQueue* task_queue,
137 double start_time) {}
138
139 void WorkerSchedulerImpl::didProcessTask(TaskQueue* task_queue,
140 double start_time,
141 double end_time) {
142 base::TimeTicks start_time_ticks =
143 MonotonicTimeInSecondsToTimeTicks(start_time);
144 base::TimeTicks end_time_ticks = MonotonicTimeInSecondsToTimeTicks(end_time);
145
146 load_tracker_.RecordTaskTime(start_time_ticks, end_time_ticks);
147 }
148
108 } // namespace scheduler 149 } // namespace scheduler
109 } // namespace blink 150 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698