Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2749373002: Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788) (Closed)

Created:
3 years, 9 months ago by pquitslund
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct target of ADD_MISSING_REQUIRED_ARGUMENT fixes (flutter-intellij#788) * corrects insert target of `ADD_MISSING_REQUIRED_ARGUMENT` fixes * updates `assertHasFix` to optionally verify fix target R=brianwilkerson@google.com Fixes: https://github.com/flutter/flutter-intellij/issues/788 Committed: https://github.com/dart-lang/sdk/commit/f33d072d915e945386762767bf2741fa4a996eaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
3 years, 9 months ago (2017-03-15 19:45:00 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-15 20:21:50 UTC) #3
pquitslund
3 years, 9 months ago (2017-03-15 20:27:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f33d072d915e945386762767bf2741fa4a996eaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698