DevTools: greyed-out console suggestion should not clash with console history

third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 43 matching lines @@
    * @param {number=} maxItemsHeight
    * @param {boolean=} captureEnter
    */
   constructor(suggestBoxDelegate, maxItemsHeight, captureEnter) {
     this._suggestBoxDelegate = suggestBoxDelegate;
     this._maxItemsHeight = maxItemsHeight;
     this._captureEnter = captureEnter;
     this._rowHeight = 17;
     this._userInteracted = false;
     this._userEnteredText = '';
+    this._defaultSelectionIsDimmed = false;
+
     /** @type {?string} */
     this._onlyCompletion = null;
 
     /** @type {!UI.ListControl<!UI.SuggestBox.Suggestion>} */
     this._list = new UI.ListControl(this, UI.ListMode.EqualHeightItems);
     this._element = this._list.element;
     this._element.classList.add('suggest-box');
     this._element.addEventListener('mousedown', event => event.preventDefault(), true);
 
     this._glassPane = new UI.GlassPane();
     this._glassPane.setAnchorBehavior(UI.GlassPane.AnchorBehavior.PreferBottom);
     this._glassPane.setSetOutsideClickCallback(this.hide.bind(this));
     var shadowRoot = UI.createShadowRootWithCoreStyles(this._glassPane.contentElement, 'ui/suggestBox.css');
     shadowRoot.appendChild(this._element);
   }
 
   /**
    * @param {boolean} value
    */
   setDefaultSelectionIsDimmed(value) {
+    this._defaultSelectionIsDimmed = value;
     this._element.classList.toggle('default-selection-is-dimmed', value);
   }
 
   /**
    * @param {boolean} value
    */
   _setUserInteracted(value) {
     this._userInteracted = value;
     this._element.classList.toggle('user-has-interacted', value);
   }
@@ skipping 158 matching lines @@
   /**
    * @override
    * @param {?UI.SuggestBox.Suggestion} from
    * @param {?UI.SuggestBox.Suggestion} to
    * @param {?Element} fromElement
    * @param {?Element} toElement
    */
   selectedItemChanged(from, to, fromElement, toElement) {
     if (fromElement)
       fromElement.classList.remove('selected', 'force-white-icons');
-    if (toElement)
-      toElement.classList.add('selected', 'force-white-icons');
+    if (toElement) {
+      toElement.classList.add('selected');
+      if (fromElement || this._userInteracted || !this._defaultSelectionIsDimmed)

[dgozman, 2017/03/15 21:17:43]

Why check for |fromElement|?

[lushnikov, 2017/03/16 08:25:46]

In this case the _userInteracted is not yet updated

+        toElement.classList.add('force-white-icons');
+    }
     if (!to)
       return;
     this._applySuggestion(true);
   }
 
   /**
    * @param {!UI.SuggestBox.Suggestions} completions
    * @param {boolean} canShowForSingleItem
    * @param {string} userEnteredText
    * @return {boolean}
@@ skipping 100 matching lines @@
 
 /**
  * @typedef {!{text: string, subtitle: (string|undefined), iconType: (string|undefined), priority: (number|undefined), isSecondary: (boolean|undefined), title: (string|undefined)}}
  */
 UI.SuggestBox.Suggestion;
 
 /**
  * @typedef {!Array<!UI.SuggestBox.Suggestion>}
  */
 UI.SuggestBox.Suggestions;