Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h

Issue 2749313002: Move slider implemention to use pointer capture (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
index 8082e82e4cc522f373f63851593ebac08e96420e..a7cd465a299e9e0d25f41fe741f58d8f86c8b402 100644
--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
@@ -41,6 +41,7 @@ namespace blink {
class HTMLInputElement;
class Event;
class TouchEvent;
+class PointerEvent;
class SliderThumbElement final : public HTMLDivElement {
public:
@@ -48,7 +49,7 @@ class SliderThumbElement final : public HTMLDivElement {
void setPositionFromValue();
- void dragFrom(const LayoutPoint&);
+ void dragFrom(const PointerEvent*);
void defaultEventHandler(Event*) override;
bool willRespondToMouseMoveEvents() override;
bool willRespondToMouseClickEvents() override;
@@ -56,7 +57,7 @@ class SliderThumbElement final : public HTMLDivElement {
const AtomicString& shadowPseudoId() const override;
HTMLInputElement* hostInput() const;
void setPositionFromPoint(const LayoutPoint&);
- void stopDragging();
+ void releasePointerCapture();
private:
SliderThumbElement(Document&);
@@ -66,9 +67,12 @@ class SliderThumbElement final : public HTMLDivElement {
bool matchesReadOnlyPseudoClass() const override;
bool matchesReadWritePseudoClass() const override;
Node* focusDelegate() override;
+ void requestPointerCapture(int pointerId);
+ void stopDragging();
void startDragging();
bool m_inDragMode;
+ int m_requestedPointerIdToCapture;
};
inline Element* SliderThumbElement::cloneElementWithoutAttributesAndChildren() {

Powered by Google App Engine
This is Rietveld 408576698