Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3059)

Unified Diff: base/task_scheduler/scheduler_worker_pool_params.cc

Issue 2749303002: [reference - do not submit] Always create four pools in TaskSchedulerImpl. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_params.h ('k') | base/task_scheduler/task_scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/scheduler_worker_pool_params.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_params.cc b/base/task_scheduler/scheduler_worker_pool_params.cc
index 43a66d0f87f9208324ed9f34153cd4e7621bc0a3..1dfe3156a4e6c099fe7f1b4af9e2406db39ced4c 100644
--- a/base/task_scheduler/scheduler_worker_pool_params.cc
+++ b/base/task_scheduler/scheduler_worker_pool_params.cc
@@ -6,16 +6,17 @@
namespace base {
+SchedulerWorkerPoolParams::SchedulerWorkerPoolParams()
+ : standby_thread_policy_(StandbyThreadPolicy::ONE),
+ max_threads_(0),
+ backward_compatibility_(SchedulerBackwardCompatibility::DISABLED) {}
+
SchedulerWorkerPoolParams::SchedulerWorkerPoolParams(
- const std::string& name,
- ThreadPriority priority_hint,
StandbyThreadPolicy standby_thread_policy,
int max_threads,
TimeDelta suggested_reclaim_time,
SchedulerBackwardCompatibility backward_compatibility)
- : name_(name),
- priority_hint_(priority_hint),
- standby_thread_policy_(standby_thread_policy),
+ : standby_thread_policy_(standby_thread_policy),
max_threads_(max_threads),
suggested_reclaim_time_(suggested_reclaim_time),
backward_compatibility_(backward_compatibility) {}
@@ -26,4 +27,8 @@ SchedulerWorkerPoolParams::SchedulerWorkerPoolParams(
SchedulerWorkerPoolParams& SchedulerWorkerPoolParams::operator=(
const SchedulerWorkerPoolParams& other) = default;
+bool SchedulerWorkerPoolParams::IsValid() const {
+ return max_threads_ > 0 && suggested_reclaim_time_ >= TimeDelta();
+}
+
} // namespace base
« no previous file with comments | « base/task_scheduler/scheduler_worker_pool_params.h ('k') | base/task_scheduler/task_scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698