third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py - Issue 2749253002: bindings: Expand typedefs before generating union files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 2749253002: bindings: Expand typedefs before generating union files. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/code_generator_v8.py ('K') | « third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_individual.py ('k') | third_party/WebKit/Source/bindings/scripts/idl_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

index eb412e76241cc2aa42e8a2221fd83b5ec2a2c957..5045270e789e9d3b5d9359fb680e4f15241efc4a 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

@@ -285,11 +285,6 @@ def compute_interfaces_info_overall(info_individuals):

else:

dependencies_other_component_include_paths.append(include_path)

- for union_type in interface_info.get('union_types', []):

- name = shorten_union_name(union_type)

- dependencies_include_paths.append(

- 'bindings/%s/v8/%s.h' % (component, name))

interface_info.update({

'dependencies_full_paths': dependencies_full_paths,

'dependencies_include_paths': dependencies_include_paths,