Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 27491002: Cosmetic: Add macros for NaN, undefined and Infinity to native js code. (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Cosmetic: Add macros for NaN, undefined and Infinity to native js code. Nobody should need to use $NaN, 0/0, 1/0 and void 0. R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -128 lines) Patch
M src/array.js View 5 chunks +6 lines, -6 lines 0 comments Download
M src/array-iterator.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/d8.js View 7 chunks +7 lines, -7 lines 0 comments Download
M src/date.js View 10 chunks +16 lines, -16 lines 0 comments Download
M src/debug-debugger.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/i18n.js View 8 chunks +8 lines, -8 lines 0 comments Download
M src/json.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/liveedit-debugger.js View 6 chunks +13 lines, -13 lines 0 comments Download
M src/macros.py View 1 chunk +5 lines, -0 lines 0 comments Download
M src/math.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/messages.js View 8 chunks +10 lines, -10 lines 0 comments Download
M src/mirror-debugger.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/object-observe.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/proxy.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp.js View 4 chunks +4 lines, -4 lines 0 comments Download
M src/runtime.js View 2 chunks +4 lines, -4 lines 0 comments Download
M src/string.js View 5 chunks +4 lines, -5 lines 0 comments Download
M src/v8natives.js View 20 chunks +34 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 2 months ago (2013-10-16 09:02:33 UTC) #1
mvstanton
lgtm
7 years, 2 months ago (2013-10-17 07:47:23 UTC) #2
Yang
7 years, 2 months ago (2013-10-17 10:02:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17252 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698