third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/HAREntry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index 829f21fc5fb022e851f68486f62c318dd04bd7f7..17319a80b55e5af47969ca4edbae0cafb7255d4f 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -400,9 +400,7 @@ Network.NetworkLogView = class extends UI.VBox {

SDK.ResourceTreeModel.Events.DOMContentLoaded, this._domContentLoadedEventFired, this);

}

- var networkLog = SDK.NetworkLog.fromTarget(target);

- if (networkLog)

- networkLog.requests().forEach(this._appendRequest.bind(this));

+ SDK.networkLog.requestsForTarget(target).forEach(this._appendRequest.bind(this));

}

/**

@@ -1026,8 +1024,7 @@ Network.NetworkLogView = class extends UI.VBox {

// Pick provisional load requests.

var requestsToPick = [];

- var networkLog = SDK.NetworkLog.fromTarget(frame.target());

- var requests = networkLog ? networkLog.requests() : [];

+ var requests = SDK.networkLog.requestsForTarget(frame.target());

for (var i = 0; i < requests.length; ++i) {

var request = requests[i];

if (request.loaderId === loaderId)