third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html - Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image.html ('k') | third_party/WebKit/Source/devtools/front_end/audits/AuditController.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

diff --git a/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html b/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

index 6dd373b766cd865feef9bb8ade94f8b20a8e6fd3..5fa1d676fc76419ef2c15f5950a427bc7872bc08 100644

--- a/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

+++ b/third_party/WebKit/LayoutTests/inspector/network/network-status-non-http.html

@@ -16,7 +16,7 @@ function test()

var urls = document.evaluate("//tbody/tr/td[position()=1]/@title", dataGrid, null, XPathResult.ORDERED_NODE_SNAPSHOT_TYPE, null);

var outputStrings = [];

- for (var request of SDK.NetworkLog.fromTarget(SDK.targetManager.mainTarget())._requests) {

+ for (var request of SDK.networkLog.requestsForTarget(SDK.targetManager.mainTarget())) {

var line = request.displayName + ":" + request.statusCode + " " + request.statusText

if (request.failed)

line += "(failed)";