Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html
index bd6bfa102b662347f27a531bf1adefd9dfec72c0..033ab7a3b6156a8e680e8b2ad2b1190650507524 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/x-frame-options-deny.html
@@ -18,7 +18,7 @@ function test()
function responseReceived(requestId, time, resourceType, response)
{
- var request = InspectorTest.networkLog.requestForId(requestId);
+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);
if (/x-frame-options-deny\.cgi/.exec(request.url())) {
InspectorTest.addResult("Received response for x-frame-options-deny.cgi");
InspectorTest.addResult("SUCCESS");
@@ -28,14 +28,14 @@ function test()
function loadingFinished(requestId, finishTime)
{
- var request = InspectorTest.networkLog.requestForId(requestId);
+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);
if (/x-frame-options-deny\.cgi/.exec(request.url()))
InspectorTest.completeTest();
}
function loadingFailed(requestId, time, localizedDescription, canceled)
{
- var request = InspectorTest.networkLog.requestForId(requestId);
+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);
if (/x-frame-options-deny\.cgi/.exec(request.url())) {
InspectorTest.addResult("TODO(mkwst): This started failing when we moved XFO to the browser.");
InspectorTest.completeTest();

Powered by Google App Engine
This is Rietveld 408576698