third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html - Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html

Issue 2749043005: [DevTools] Make NetworkLog a singleton, and not an SDKModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/network/network-datareceived.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html

index 4797aeeba2eb9cc29724a0961645aa765b1b7fa3..75299456b51eda3623abca3c21ed187b2246b372 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/download.html

@@ -18,7 +18,7 @@ function test()

function responseReceived(requestId, time, resourceType, response)

{

- var request = InspectorTest.networkLog.requestForId(requestId);

+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);

if (/download\.zzz/.exec(request.url())) {

InspectorTest.addResult("Received response for download.zzz");

InspectorTest.addResult("SUCCESS");

@@ -28,14 +28,14 @@ function test()

function loadingFinished(requestId, finishTime)

{

- var request = InspectorTest.networkLog.requestForId(requestId);

+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);

if (/download\.zzz/.exec(request.url()))

InspectorTest.completeTest();

}

function loadingFailed(requestId, time, localizedDescription, canceled)

{

- var request = InspectorTest.networkLog.requestForId(requestId);

+ var request = InspectorTest.networkLog.requestForId(InspectorTest.mainTarget, requestId);

if (/download\.zzz/.exec(request.url()))

InspectorTest.completeTest();

}