Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: tools/clang/plugins/ChromeClassTester.cpp

Issue 2749043004: Clang plugin: Support for Blink in web/. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsAction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/ChromeClassTester.cpp
diff --git a/tools/clang/plugins/ChromeClassTester.cpp b/tools/clang/plugins/ChromeClassTester.cpp
index b0cc3db5aed56da1435b1ec19dff3c48fa3ff423..58636992fb8e0d8467bdeb168ec8283723e5f6c4 100644
--- a/tools/clang/plugins/ChromeClassTester.cpp
+++ b/tools/clang/plugins/ChromeClassTester.cpp
@@ -238,8 +238,10 @@ void ChromeClassTester::BuildBannedLists() {
banned_namespaces_.emplace("std");
banned_namespaces_.emplace("__gnu_cxx");
- if (options_.enforce_in_thirdparty_webkit) {
+ if (options_.enforce_in_blink) {
allowed_directories_.emplace("/third_party/WebKit/");
+ } else {
+ banned_directories_.emplace("/web/");
}
Avi (use Gerrit) 2017/03/16 00:33:18 To be clear, the first branch of the if() has an i
tkent 2017/03/16 00:35:58 That's right. I'll add comments.
banned_directories_.emplace("/third_party/");
« no previous file with comments | « no previous file | tools/clang/plugins/FindBadConstructsAction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698