Clang plugin: Support for Blink in web/.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 34 matching lines @@
 ChromeClassTester::~ChromeClassTester() {}
 
 void ChromeClassTester::CheckTag(TagDecl* tag) {
   // We handle class types here where we have semantic information. We can only
   // check structs/classes/enums here, but we get a bunch of nice semantic
   // information instead of just parsing information.
   if (InBannedNamespace(tag))
     return;
 
   SourceLocation location = tag->getInnerLocStart();
-  LocationType location_type = ClassifyLocation(location);
+  LocationType location_type = ClassifyLocation(location, tag);
   if (location_type == LocationType::kThirdParty)
     return;
 
   if (CXXRecordDecl* record = dyn_cast<CXXRecordDecl>(tag)) {
     // We sadly need to maintain a blacklist of types that violate these
     // rules, but do so for good reason or due to limitations of this
     // checker (i.e., we don't handle extern templates very well).
     std::string base_name = record->getNameAsString();
     if (IsIgnoredType(base_name))
       return;
@@ skipping 23 matching lines @@
 
   DiagnosticIDs::Level level = getErrorLevel() == DiagnosticsEngine::Error
       ? DiagnosticIDs::Error : DiagnosticIDs::Warning;
 
   unsigned id = diagnostic().getDiagnosticIDs()->getCustomDiagID(level, err);
   DiagnosticBuilder builder = diagnostic().Report(full, id);
 
 }
 
 ChromeClassTester::LocationType ChromeClassTester::ClassifyLocation(
-    SourceLocation loc) {
+    SourceLocation loc,
+    const Decl* record) {
+  std::string ns = GetNamespace(record);
+  if (ns == "blink" || ns == "WTF")
+    return LocationType::kBlink;
+
   if (instance().getSourceManager().isInSystemHeader(loc))
     return LocationType::kThirdParty;
 
   std::string filename;
   if (!GetFilename(loc, &filename)) {
     // If the filename cannot be determined, simply treat this as a banned
     // location, instead of going through the full lookup process.
     return LocationType::kThirdParty;
   }
 
@@ skipping 40 matching lines @@
     size_needed = WideCharToMultiByte(CP_UTF8, 0, full_utf16.data(), -1,
                                       nullptr, 0, nullptr, nullptr);
     filename.resize(size_needed);
     WideCharToMultiByte(CP_UTF8, 0, full_utf16.data(), -1, &filename[0],
                         size_needed, nullptr, nullptr);
   }
 
   std::replace(filename.begin(), filename.end(), '\\', '/');
 #endif
 
-  for (const std::string& blink_dir : blink_directories_) {
-    // If any of the allowed directories occur as a component in filename,
-    // this file is allowed.
-    assert(blink_dir.front() == '/' && "Allowed dir must start with '/'");
-    assert(blink_dir.back() == '/' && "Allowed dir must end with '/'");
-
-    if (filename.find(blink_dir) != std::string::npos)
-      return LocationType::kBlink;
-  }
-
   for (const std::string& banned_dir : banned_directories_) {
     // If any of the banned directories occur as a component in filename,
     // this file is rejected.
     assert(banned_dir.front() == '/' && "Banned dir must start with '/'");
     assert(banned_dir.back() == '/' && "Banned dir must end with '/'");
 
     if (filename.find(banned_dir) != std::string::npos)
       return LocationType::kThirdParty;
   }
 
@@ skipping 46 matching lines @@
         source_manager.getImmediateExpansionRange(record_location).first;
   }
 
   return false;
 }
 
 void ChromeClassTester::BuildBannedLists() {
   banned_namespaces_.emplace("std");
   banned_namespaces_.emplace("__gnu_cxx");
 
-  blink_directories_.emplace("/third_party/WebKit/");
-
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");
   banned_directories_.emplace("/breakpad/");
   banned_directories_.emplace("/courgette/");
   banned_directories_.emplace("/ppapi/");
   banned_directories_.emplace("/testing/");
   banned_directories_.emplace("/v8/");
   banned_directories_.emplace("/sdch/");
   banned_directories_.emplace("/frameworks/");
 
@@ skipping 86 matching lines @@
   }
 
   *filename = ploc.getFilename();
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }