Clang plugin: Support for Blink in web/.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
 #include <algorithm>
@@ skipping 220 matching lines @@
         source_manager.getImmediateExpansionRange(record_location).first;
   }
 
   return false;
 }
 
 void ChromeClassTester::BuildBannedLists() {
   banned_namespaces_.emplace("std");
   banned_namespaces_.emplace("__gnu_cxx");
 
-  if (options_.enforce_in_thirdparty_webkit) {
+  if (options_.enforce_in_blink) {
     allowed_directories_.emplace("/third_party/WebKit/");
+  } else {
+    banned_directories_.emplace("/web/");
   }

[Avi (use Gerrit), 2017/03/16 00:33:18]

To be clear, the first branch of the if() has an implicit "allow /web/" but
that's implied because it's top-level, and the second branch has an implicit
"ban /third_party/WebKit/" but that's also implied by the ban of /third_party/.?

[tkent, 2017/03/16 00:35:58]

That's right.
I'll add comments.

 
   banned_directories_.emplace("/third_party/");
   banned_directories_.emplace("/native_client/");
   banned_directories_.emplace("/breakpad/");
   banned_directories_.emplace("/courgette/");
   banned_directories_.emplace("/ppapi/");
   banned_directories_.emplace("/testing/");
   banned_directories_.emplace("/v8/");
   banned_directories_.emplace("/sdch/");
   banned_directories_.emplace("/frameworks/");
@@ skipping 87 matching lines @@
   }
 
   *filename = ploc.getFilename();
   return true;
 }
 
 DiagnosticsEngine::Level ChromeClassTester::getErrorLevel() {
   return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
                                             : DiagnosticsEngine::Warning;
 }