Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2749033003: fasta.Token implement analyzer.Token.isOperator (Closed)

Created:
3 years, 9 months ago by danrubel
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fasta.Token implement analyzer.Token.isOperator One more step closer to fasta.Token implements analyzer.Token R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/32f492b54baee7c60b8e75d99642b3b444e2d3e1

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -65 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/precedence.dart View 3 chunks +101 lines, -65 lines 1 comment Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/test/scanner_roundtrip_test.dart View 2 chunks +146 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
3 years, 9 months ago (2017-03-14 19:30:56 UTC) #2
Paul Berry
lgtm
3 years, 9 months ago (2017-03-14 19:37:16 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as 32f492b54baee7c60b8e75d99642b3b444e2d3e1 (presubmit successful).
3 years, 9 months ago (2017-03-14 22:07:05 UTC) #5
ahe
3 years, 9 months ago (2017-03-15 14:54:25 UTC) #6
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/2749033003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/scanner/precedence.dart (right):

https://codereview.chromium.org/2749033003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/scanner/precedence.dart:112: isOperator: true);
Are you sure about that?

Isn't an operator something that operates on expressions?

Powered by Google App Engine
This is Rietveld 408576698