Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/resources/settings/site_settings/edit_exception_dialog.js

Issue 2749023008: [MD settings] edit content settings exceptions (Closed)
Patch Set: unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
diff --git a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js b/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
index e44f6b794162f77309aeea3a17da7d649bf23c7e..968b5d10396637b4f04ae1bf8aa06e28a1c4e8ea 100644
--- a/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
+++ b/chrome/browser/resources/settings/site_settings/edit_exception_dialog.js
@@ -39,21 +39,17 @@ Polymer({
/** @private */
onActionButtonTap_: function() {
if (this.model.origin != this.origin_) {
- // TODO(dpapad): Only COOKIES category can be edited currently,
- // crbug.com/695578.
- var category = settings.ContentSettingsTypes.COOKIES;
-
// The way to "edit" an exception is to remove it and and a new one.
this.browserProxy_.resetCategoryPermissionForOrigin(
this.model.origin,
this.model.embeddingOrigin,
- category,
+ this.model.category,
this.model.incognito);
this.browserProxy_.setCategoryPermissionForOrigin(
this.origin_,
this.origin_,
- category,
+ this.model.category,
this.model.setting,
this.model.incognito);
}

Powered by Google App Engine
This is Rietveld 408576698