[MD settings] edit content settings exceptions

chrome/browser/resources/settings/site_settings/site_settings_behavior.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Behavior common to Site Settings classes.
  */
 
 /** @polymerBehavior */
 var SiteSettingsBehaviorImpl = {
@@ skipping 129 matching lines @@
     // as well.
     originOrPattern = originOrPattern.replace('*://', '');
     originOrPattern = originOrPattern.replace('[*.]', '');
     return new URL(this.ensureUrlHasScheme(originOrPattern));
   },
 
   /**
    * Convert an exception (received from the C++ handler) to a full
    * SiteException.
    * @param {!Object} exception The raw site exception from C++.
    * @return {SiteException} The expanded (full) SiteException.

[dpapad, 2017/03/20 22:22:47]

SiteException typedef does not have a |category| field,
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_s....


Should it be also updated? Having said that, it is a bit alarming that the JS
compiler does not throw any error for this.

[dschuyler, 2017/03/21 00:12:58]

I made a CL at https://codereview.chromium.org/2760183002/
to explore this further.

    * @private
    */
   expandSiteException: function(exception) {
     var origin = exception.origin;
     var embeddingOrigin = exception.embeddingOrigin;
     var embeddingDisplayName = '';
     if (origin != embeddingOrigin) {
       embeddingDisplayName =
           this.getEmbedderString(embeddingOrigin, this.category);
     }
 
     return {
+      category: this.category,
       origin: origin,
       displayName: exception.displayName,
       embeddingOrigin: embeddingOrigin,
       embeddingDisplayName: embeddingDisplayName,
       incognito: exception.incognito,
       setting: exception.setting,
       source: exception.source,
     };
   },
 
 };
 
 /** @polymerBehavior */
 var SiteSettingsBehavior = [SiteSettingsBehaviorImpl];