Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 27490005: Make CropRect immutable after construction. (Closed)

Created:
7 years, 2 months ago by Stephen White
Modified:
7 years, 2 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Make CropRect immutable after construction. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11819

Patch Set 1 #

Patch Set 2 : Remove now-stale comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -25 lines) Patch
M include/core/SkImageFilter.h View 1 3 chunks +16 lines, -16 lines 0 comments Download
M src/core/SkImageFilter.cpp View 3 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
PTAL. Thanks!
7 years, 2 months ago (2013-10-16 16:13:55 UTC) #1
reed1
a thing of simplistic beauty -- lgtm
7 years, 2 months ago (2013-10-16 17:27:04 UTC) #2
Stephen White
7 years, 2 months ago (2013-10-16 18:07:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r11819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698