Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

Issue 2748993004: Don't call NOTIMPLEMENTED for caps lock state on non-Mac/Win platforms. (Closed)
Patch Set: Feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
index 72f23efaa2e348455e95389a3c6d244515b9c8fb..f45894a8c4d0dc0d1d1c072dbb815575b1855e5a 100644
--- a/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
@@ -437,7 +437,8 @@ bool KeyboardEventManager::currentCapsLockState() {
#elif OS(MACOSX)
return GetCurrentKeyModifiers() & alphaLock;
#else
- NOTIMPLEMENTED();
+ // Caps lock state use is limited to Mac password input
+ // fields, so just return false. See http://crbug.com/618739.
return false;
#endif
case OverrideCapsLockState::On:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698