Don't call NOTIMPLEMENTED for caps lock state on non-Mac/Win platforms.

third_party/WebKit/Source/core/input/KeyboardEventManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "KeyboardEventManager.h"
 
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/Element.h"
 #include "core/editing/Editor.h"
 #include "core/events/KeyboardEvent.h"
@@ skipping 419 matching lines @@
 
 bool KeyboardEventManager::currentCapsLockState() {
   switch (s_overrideCapsLockState) {
     case OverrideCapsLockState::Default:
 #if OS(WIN)
       // FIXME: Does this even work inside the sandbox?
       return GetKeyState(VK_CAPITAL) & 1;
 #elif OS(MACOSX)
       return GetCurrentKeyModifiers() & alphaLock;
 #else
-      NOTIMPLEMENTED();
+      // Note that the caps lock state provided by this method is only

[wkorman, 2017/03/15 00:03:14]

Two alternatives to this patch:

1. modify LayoutTextControlSingleLine event-forwarding logic (intended to handle
paint invalidation for the control on caps-lock state change) to also consider
the platform in some manner. For example, we could add a method to
KeyboardEventManager that provides visibility into whether caps lock state is
available for the current platform, and have LTCSL check that before calling
currentCapsLockState().

ref:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

This seems like more of a maintenance headache than the benefit it would
provide, but I could be convinced if you feel strongly.

2. finish implementing currentCapsLockState for all platforms. This doesn't seem
worthwhile currently since we only need/use this for Mac theme painting.

[dtapuska, 2017/03/15 00:11:04]

this lgtm. This NOTIMPLEMENTED use to be a no-op before the unified logging was
added to blink. It then changed to a warning that was always generated, so I'm
fine ignoring it for now.

+      // used to paint a caps lock icon for Mac password input fields.
+      // We may as well just return false if we end up here. Calling
+      // NOTIMPLEMENTED() just produces a verbose debug stack trace
+      // whenever an event is forwarded to a
+      // LayoutTextControlSingleLine on platforms lacking an
+      // implementation, such as CrOS, which isn't helpful as we have
+      // no current plans or need to use this.

[stevenjb, 2017/03/15 01:25:33]

This is helpful, but maybe a little bit verbose :) You could put this text in
the bug, simplify it here, and refer to the bug (e.g. see crbug.com/1234).

[wkorman, 2017/03/15 08:18:53]

Done.

       return false;
 #endif
     case OverrideCapsLockState::On:
       return true;
     case OverrideCapsLockState::Off:
     default:
       return false;
   }
 }
 
@@ skipping 17 matching lines @@
   if (currentModifiers & ::cmdKey)
     modifiers |= WebInputEvent::MetaKey;
 #else
   // TODO(crbug.com/538289): Implement on other platforms.
   return static_cast<WebInputEvent::Modifiers>(0);
 #endif
   return static_cast<WebInputEvent::Modifiers>(modifiers);
 }
 
 }  // namespace blink