components/password_manager/core/browser/form_fetcher_impl_unittest.cc - Issue 2748933005: Remove Obsolete HTTP SiteStatistics From PasswordStore during Migration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/form_fetcher_impl_unittest.cc

Issue 2748933005: Remove Obsolete HTTP SiteStatistics From PasswordStore during Migration (Closed)

Patch Set: Capture explicitly Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/form_fetcher_impl.cc ('k') | components/password_manager/core/browser/http_password_migrator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/form_fetcher_impl_unittest.cc

diff --git a/components/password_manager/core/browser/form_fetcher_impl_unittest.cc b/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

index 310c7baf939816a588aabb72160809a4492659ad..e3e2806d3aee9c831a77b1e4147e8abc775c866f 100644

--- a/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

+++ b/components/password_manager/core/browser/form_fetcher_impl_unittest.cc

@@ -477,7 +477,7 @@ TEST_F(FormFetcherImplTest, TryToMigrateHTTPPasswordsOnHTTPSSites) {

EXPECT_CALL(*mock_store_, AddLogin(https_form));

EXPECT_CALL(consumer_,

ProcessMatches(UnorderedElementsAre(Pointee(https_form)), 0u));

- static_cast<HttpPasswordMigrator*>(migrator_ptr.get())

+ static_cast<HttpPasswordStoreMigrator*>(migrator_ptr.get())

->OnGetPasswordStoreResults(MakeResults({http_form}));

EXPECT_THAT(form_fetcher_->GetFederatedMatches(), IsEmpty());

@@ -548,7 +548,7 @@ TEST_F(FormFetcherImplTest, StateIsWaitingDuringMigration) {

// Now perform the actual migration.

EXPECT_CALL(*mock_store_, AddLogin(https_form));

- static_cast<HttpPasswordMigrator*>(migrator_ptr.get())

+ static_cast<HttpPasswordStoreMigrator*>(migrator_ptr.get())

->OnGetPasswordStoreResults(MakeResults({http_form}));

EXPECT_EQ(FormFetcher::State::NOT_WAITING, form_fetcher_->GetState());

}