[Mac] Use Crashpad in the AlertNotificationService.xpc.

components/crash/content/app/crashpad_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 #include <string.h>
 #include <unistd.h>
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
 #include "base/files/file_path.h"
+#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/crash/content/app/crash_reporter_client.h"
 #include "third_party/crashpad/crashpad/client/crash_report_database.h"
 #include "third_party/crashpad/crashpad/client/crashpad_client.h"
 #include "third_party/crashpad/crashpad/client/crashpad_info.h"
 #include "third_party/crashpad/crashpad/client/settings.h"
 #include "third_party/crashpad/crashpad/client/simple_string_dictionary.h"
 #include "third_party/crashpad/crashpad/client/simulate_crash.h"
 
 namespace crash_reporter {
+
+namespace {
+
+base::LazyInstance<crashpad::CrashpadClient>::Leaky g_crashpad_client =
+    LAZY_INSTANCE_INITIALIZER;

[Robert Sesek, 2017/03/14 22:14:54]

Also worth noting that this is how crashpad_win.cc does things too. Should we
combine into crashpad.cc?

[Mark Mentovai, 2017/03/14 23:24:52]

Robert Sesek wrote:
Yeah, but let’s also adopt the standard and more modern

crashpad::CrashpadClient& GetCrashpadClient() {
  static crashpad::CrashpadClient* const crashpad_client = new
crashpad::CrashpadClient();
  return *crashpad_client;
}

[Robert Sesek, 2017/03/15 19:22:10]

Done. (Assuming you really did want a non-const-ref return value).

+
+}  // namespace
+
+base::mac::ScopedMachSendRight GetHandlerMachPort() {
+  return g_crashpad_client.Get().GetHandlerMachPort();
+}
+
 namespace internal {
 
 base::FilePath PlatformCrashpadInitialization(bool initial_client,
                                               bool browser_process,
                                               bool embedded_handler) {
   base::FilePath database_path;  // Only valid in the browser process.
   base::FilePath metrics_path;  // Only valid in the browser process.
   DCHECK(!embedded_handler);  // This is not used on Mac.
 
   if (initial_client) {
@@ skipping 41 matching lines @@
       std::vector<std::string> arguments;
       if (!browser_process) {
         // If this is an initial client that's not the browser process, it's
         // important that the new Crashpad handler also not be connected to any
         // existing handler. This argument tells the new Crashpad handler to
         // sever this connection.
         arguments.push_back(
             "--reset-own-crash-exception-port-to-system-default");
       }
 
-      crashpad::CrashpadClient crashpad_client;
-      bool result = crashpad_client.StartHandler(handler_path,
-                                                 database_path,
-                                                 metrics_path,
-                                                 url,
-                                                 process_annotations,
-                                                 arguments,
-                                                 true,
-                                                 false);
+      bool result = g_crashpad_client.Get().StartHandler(

[Mark Mentovai, 2017/03/14 23:24:52]

clang-format’s worse, and I guess I’m not supposed to say anything, but I can
still groan. :(

[Robert Sesek, 2017/03/15 19:22:10]

https://bugs.chromium.org/p/chromium/issues/detail?id=690114

+          handler_path, database_path, metrics_path, url, process_annotations,
+          arguments, true, false);
 
       // If this is an initial client that's not the browser process, it's
       // important to sever the connection to any existing handler. If
       // StartHandler() failed, call UseSystemDefaultHandler() to drop the link
       // to the existing handler.
       if (!result && !browser_process) {
         crashpad::CrashpadClient::UseSystemDefaultHandler();
       }
     }  // @autoreleasepool
   }
 
   return database_path;
 }
 
 }  // namespace internal
 }  // namespace crash_reporter