Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: ios/chrome/browser/context_menu/context_menu_egtest.mm

Issue 2748843004: Mark testContextMenuOpenInNewTabFromTallPage FLAKY. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <EarlGrey/EarlGrey.h> 5 #import <EarlGrey/EarlGrey.h>
6 #import <UIKit/UIKit.h> 6 #import <UIKit/UIKit.h>
7 #import <XCTest/XCTest.h> 7 #import <XCTest/XCTest.h>
8 8
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "ios/chrome/browser/ui/ui_util.h" 10 #include "ios/chrome/browser/ui/ui_util.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 // Verify url and tab count. 182 // Verify url and tab count.
183 [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText( 183 [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
184 destinationURL.GetContent())] 184 destinationURL.GetContent())]
185 assertWithMatcher:grey_notNil()]; 185 assertWithMatcher:grey_notNil()];
186 chrome_test_util::AssertMainTabCount(2U); 186 chrome_test_util::AssertMainTabCount(2U);
187 } 187 }
188 188
189 // Tests "Open in New Tab" on context menu on a link that requires scrolling 189 // Tests "Open in New Tab" on context menu on a link that requires scrolling
190 // on the page to verify that context menu can be properly triggered in the 190 // on the page to verify that context menu can be properly triggered in the
191 // current screen view. 191 // current screen view.
192 - (void)testContextMenuOpenInNewTabFromTallPage { 192 // TODO(crbug.com/701104): This test is flaky because sometimes it doesn't
193 // scroll down far enough for the link to be visible.
194 - (void)FLAKY_testContextMenuOpenInNewTabFromTallPage {
193 // Set up test simple http server. 195 // Set up test simple http server.
194 std::map<GURL, std::string> responses; 196 std::map<GURL, std::string> responses;
195 GURL initialURL = 197 GURL initialURL =
196 web::test::HttpServer::MakeUrl("http://scenarioContextMenuOpenInNewTab"); 198 web::test::HttpServer::MakeUrl("http://scenarioContextMenuOpenInNewTab");
197 GURL destinationURL = web::test::HttpServer::MakeUrl("http://destination"); 199 GURL destinationURL = web::test::HttpServer::MakeUrl("http://destination");
198 200
199 // The initial page contains a link to the destination page that is below a 201 // The initial page contains a link to the destination page that is below a
200 // really tall div so that scrolling is required. 202 // really tall div so that scrolling is required.
201 responses[initialURL] = 203 responses[initialURL] =
202 "<div style='height:4000px'></div>" 204 "<div style='height:4000px'></div>"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 SelectTabAtIndexInCurrentMode(1U); 248 SelectTabAtIndexInCurrentMode(1U);
247 249
248 // Verify url and tab count. 250 // Verify url and tab count.
249 [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText( 251 [[EarlGrey selectElementWithMatcher:chrome_test_util::OmniboxText(
250 destinationURL.GetContent())] 252 destinationURL.GetContent())]
251 assertWithMatcher:grey_notNil()]; 253 assertWithMatcher:grey_notNil()];
252 chrome_test_util::AssertMainTabCount(2U); 254 chrome_test_util::AssertMainTabCount(2U);
253 } 255 }
254 256
255 @end 257 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698