Move didReceiveTitle and related stuff to RenderFrame.

Move didReceiveTitle and related stuff to RenderFrame.

BUG=361761
TEST=no visible change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269641

[nasko, 2014-05-09 16:39:29]

LGTM with a nit.

I'm also curious why move the caching of the last set content encoding to the
browser side?

https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:3483: if (!entry && rvh !=
GetRenderViewHost())
Shouldn't this change to check the RFH?

[Avi (use Gerrit), 2014-05-09 16:44:06]

> I'm also curious why move the caching of the last set content encoding to the
browser side?

No one wants values to be held on the RFH that are only used at the top level.
My choices were to move it to the other side of IPC, or perhaps drop it onto
RenderWidget. But a title didn't seem to be to be widget-y. I thought the widget
concerned itself with graphics, etc, so I moved it to WC.

https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
File content/browser/web_contents/web_contents_impl.cc (right):

https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
content/browser/web_contents/web_contents_impl.cc:3483: if (!entry && rvh !=
GetRenderViewHost())
On 2014/05/09 16:39:29, nasko wrote:
> Shouldn't this change to check the RFH?

I'm not good at understanding the current vs pending RVH and stuff, so I wanted
to keep it safe.

[nasko, 2014-05-09 16:47:35]

On 2014/05/09 16:44:06, Avi wrote:
> > I'm also curious why move the caching of the last set content encoding to
the
> browser side?
> 
> No one wants values to be held on the RFH that are only used at the top level.
> My choices were to move it to the other side of IPC, or perhaps drop it onto
> RenderWidget. But a title didn't seem to be to be widget-y. I thought the
widget
> concerned itself with graphics, etc, so I moved it to WC.

Good point.
 
>
https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
> File content/browser/web_contents/web_contents_impl.cc (right):
> 
>
https://codereview.chromium.org/274883002/diff/1/content/browser/web_contents...
> content/browser/web_contents/web_contents_impl.cc:3483: if (!entry && rvh !=
> GetRenderViewHost())
> On 2014/05/09 16:39:29, nasko wrote:
> > Shouldn't this change to check the RFH?
> 
> I'm not good at understanding the current vs pending RVH and stuff, so I
wanted
> to keep it safe.

Let's at least put a TODO, so we can change it later in subsequent CL.

[Avi (use Gerrit), 2014-05-09 16:50:55]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-05-09 16:54:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/274883002/20001

[commit-bot: I haz the power, 2014-05-10 18:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-10 18:53:26]

Failed to apply patch for content/renderer/render_view_impl.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/renderer/render_view_impl.h
  Hunk #1 FAILED at 654.
  Hunk #2 succeeded at 674 (offset 4 lines).
  Hunk #3 succeeded at 1000 (offset 4 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
content/renderer/render_view_impl.h.rej

Patch:       content/renderer/render_view_impl.h
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h
b/content/renderer/render_view_impl.h
index
c174bcf76c07e03e6dc1cf7e8066c1e665ff4e13..6a948375bfa9df13a6fbc54a919987f8734c7a25
100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -654,9 +654,6 @@ class CONTENT_EXPORT RenderViewImpl
   void didCreateDataSource(blink::WebLocalFrame* frame,
                            blink::WebDataSource* datasource);
   void didClearWindowObject(blink::WebLocalFrame* frame, int world_id);
-  void didReceiveTitle(blink::WebLocalFrame* frame,
-                       const blink::WebString& title,
-                       blink::WebTextDirection direction);
   void didChangeIcon(blink::WebLocalFrame*, blink::WebIconURL::Type);
   void didUpdateCurrentHistoryItem(blink::WebLocalFrame* frame);
   void didChangeScrollOffset(blink::WebLocalFrame* frame);
@@ -670,27 +667,9 @@ class CONTENT_EXPORT RenderViewImpl
   static WindowOpenDisposition NavigationPolicyToDisposition(
       blink::WebNavigationPolicy policy);
 
-  void UpdateTitle(blink::WebFrame* frame, const base::string16& title,
-                   blink::WebTextDirection title_direction);
   void UpdateSessionHistory(blink::WebFrame* frame);
   void SendUpdateState(HistoryEntry* entry);
 
-  // Update current main frame's encoding and send it to browser window.
-  // Since we want to let users see the right encoding info from menu
-  // before finishing loading, we call the UpdateEncoding in
-  // a) function:DidCommitLoadForFrame. When this function is called,
-  // that means we have got first data. In here we try to get encoding
-  // of page if it has been specified in http header.
-  // b) function:DidReceiveTitle. When this function is called,
-  // that means we have got specified title. Because in most of webpages,
-  // title tags will follow meta tags. In here we try to get encoding of
-  // page if it has been specified in meta tag.
-  // c) function:DidFinishDocumentLoadForFrame. When this function is
-  // called, that means we have got whole html page. In here we should
-  // finally get right encoding of page.
-  void UpdateEncoding(blink::WebFrame* frame,
-                      const std::string& encoding_name);
-
   // Sends a message and runs a nested message loop.
   bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);
 
@@ -1014,11 +993,6 @@ class CONTENT_EXPORT RenderViewImpl
   // navigate to stale entries that have been cropped from our history.
   std::vector<int32> history_page_ids_;
 
-  // Page info
-----------------------------------------------------------------
-
-  // The last gotten main frame's encoding.
-  std::string last_encoding_name_;
-
   // UI state
------------------------------------------------------------------
 
   // The state of our target_url transmissions. When we receive a request to

[Avi (use Gerrit), 2014-05-10 19:57:02]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-05-10 19:59:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/avi@chromium.org/274883002/40001

[commit-bot: I haz the power, 2014-05-11 00:04:57]

Change committed as 269641