Change summary code generator to use Fasta parser.

Change summary code generator to use Fasta parser.

The end goal is to move summary logic to the front end, which means
that it won't be able to depend on analyzer.  This removes a key
dependency on analyzer (the dependency of the code generator on the
analyzer parser).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/2457a79b480c620c61f836bb6bd7b99c3d4b503a

[Paul Berry, 2017-03-14 16:38:46]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2017-03-14 17:22:40]

LGTM

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
File pkg/analyzer/tool/summary/mini_ast.dart (right):

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
pkg/analyzer/tool/summary/mini_ast.dart:193: List<ClassMember> members = pop();
Would this be better?
var members = pop() as List<ClassMember>;

[Paul Berry, 2017-03-14 17:31:36]

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
File pkg/analyzer/tool/summary/mini_ast.dart (right):

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
pkg/analyzer/tool/summary/mini_ast.dart:193: List<ClassMember> members = pop();
On 2017/03/14 17:22:40, scheglov wrote:
> Would this be better?
> var members = pop() as List<ClassMember>;

Personally, I like it better.  But IIRC, Peter has expressed performance
concerns about this, since it forces the type check to happen all the time,
regardless of whether we are in checked mode.

[scheglov, 2017-03-14 17:35:38]

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
File pkg/analyzer/tool/summary/mini_ast.dart (right):

https://codereview.chromium.org/2748803003/diff/1/pkg/analyzer/tool/summary/m...
pkg/analyzer/tool/summary/mini_ast.dart:193: List<ClassMember> members = pop();
On 2017/03/14 17:31:36, Paul Berry wrote:
> On 2017/03/14 17:22:40, scheglov wrote:
> > Would this be better?
> > var members = pop() as List<ClassMember>;
> 
> Personally, I like it better.  But IIRC, Peter has expressed performance
> concerns about this, since it forces the type check to happen all the time,
> regardless of whether we are in checked mode.

OK
Probably performance is not a concern for generators :-)
But consistency is good.
The check might start happening anyway when VM supports strong mode.

[Paul Berry, 2017-03-14 17:36:50]

Description was changed from

==========
Change summary code generator to use Fasta parser.

The end goal is to move summary logic to the front end, which means
that it won't be able to depend on analyzer.  This removes a key
dependency on analyzer (the dependency of the code generator on the
analyzer parser).
==========

to

==========
Change summary code generator to use Fasta parser.

The end goal is to move summary logic to the front end, which means
that it won't be able to depend on analyzer.  This removes a key
dependency on analyzer (the dependency of the code generator on the
analyzer parser).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2457a79b480c620c61f836bb6bd7b99c3d4b503a
==========

[Paul Berry, 2017-03-14 17:36:51]

Committed patchset #1 (id:1) manually as
2457a79b480c620c61f836bb6bd7b99c3d4b503a (presubmit successful).

[Brian Wilkerson, 2017-03-14 17:39:07]

lgtm