Invoke native methods directly

pkg/dev_compiler/lib/src/compiler/code_generator.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:collection' show HashMap, HashSet;
 import 'dart:math' show min, max;
 
 import 'package:analyzer/analyzer.dart' hide ConstantEvaluator;
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 5645 matching lines @@
 
     var result = _propertyName(name);
 
     if (useExtension == null) {
       // Dart "extension" methods. Used for JS Array, Boolean, Number, String.
       var baseType = type;
       while (baseType is TypeParameterType) {
         baseType = (baseType.element as TypeParameterElement).bound;
       }
       useExtension = baseType != null &&
           _extensionTypes.hasNativeSubtype(baseType) &&

[Jennifer Messerly, 2017/03/13 17:20:10]

you might want to fold this check into isForwardedNative member somehow? it will
check again that isNativeClass, and hasNativeSubtype here is basically just:

  bool hasNativeSubtype(DartType type) =>
      _isNativeInterface(type.element) || isNativeClass(type.element);

[vsm, 2017/03/13 20:55:26]

Done.

+          !isForwardedNativeMember(baseType, name) &&
           !isObjectMember(name);
     }
 
     return useExtension
         ? js.call('#.#', [_extensionSymbolsModule, result])
         : result;
   }
 
+  bool isForwardedNativeMember(DartType type, String name) {
+    // Don't call extension members that just forward to the underlying

[Jennifer Messerly, 2017/03/13 17:20:10]

this might be nicer as a doc comment?

[vsm, 2017/03/13 20:55:26]

Done - see below.

+    // native member.  We limit this to non-renamed members as the receiver
+    // may be a mock type.
+
+    // Note, this is an underlying assumption here that, if another native type
+    // subtypes this one, it also forwards this member to its underlying native
+    // one without renaming.
+    if (type is InterfaceType) {

[Jennifer Messerly, 2017/03/13 17:20:11]

this check could be moved to line 5665: `useExtension = baseType != null &&`

really we shouldn't get here if we don't have an InterfaceType; nothing else
would be a native class.

[vsm, 2017/03/13 20:55:26]

Done.

+      var element = type.element;
+      if (_extensionTypes.isNativeClass(element)) {
+        var member = element.lookUpMethod(name, currentLibrary) ??

[Jennifer Messerly, 2017/03/13 17:20:11]

this is a pretty slow lookup. it'll linear scan the type hierarchy 3 times. we
may want to cache more info about native types.

[vsm, 2017/03/13 20:55:26]

Done.

+            element.lookUpGetter(name, currentLibrary) ??
+            element.lookUpSetter(name, currentLibrary);
+
+        // Fields on a native class are implicitly native.
+        // Methods/getters/setters are marked external/native.
+        if (member != null) {
+          member = (member.isSynthetic && member is PropertyAccessorElement) ? member.variable : member;

[Jennifer Messerly, 2017/03/13 17:20:10]

long line

[vsm, 2017/03/13 20:55:26]

Done.

+          if (member is FieldElement || member.isExternal) {
+            var jsName = getAnnotationName(member, isJsName);
+            return jsName == null || jsName == name;
+          }
+        }
+      }
+    }
+    return false;
+  }
+
   JS.TemporaryId _emitPrivateNameSymbol(LibraryElement library, String name) {
     return _privateNames
         .putIfAbsent(library, () => new HashMap())
         .putIfAbsent(name, () {
       var id = new JS.TemporaryId(name);
       _moduleItems.add(
           js.statement('const # = Symbol(#);', [id, js.string(id.name, "'")]));
       return id;
     });
   }
@@ skipping 275 matching lines @@
   if (targetIdentifier.staticElement is! PrefixElement) return false;
   var prefix = targetIdentifier.staticElement as PrefixElement;
 
   // The library the prefix is referring to must come from a deferred import.
   var containingLibrary = resolutionMap
       .elementDeclaredByCompilationUnit(target.root as CompilationUnit)
       .library;
   var imports = containingLibrary.getImportsWithPrefix(prefix);
   return imports.length == 1 && imports[0].isDeferred;
 }