Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2748683003: Fix bugs and add instrumentation (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -30 lines) Patch
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 7 chunks +33 lines, -9 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 6 chunks +60 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-13 16:28:28 UTC) #2
scheglov
lgtm
3 years, 9 months ago (2017-03-13 17:07:57 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-13 17:12:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c91736b8e5338f56c06409cf38ab07a8fdf9b702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698