Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 274863004: Cleanup: Remove more unused entries from the iOS grit whitelist. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove more unused entries from the iOS grit whitelist. Remove resources that have no other users. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270316

Patch Set 1 : #

Patch Set 2 : fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M build/ios/grit_whitelist.txt View 1 6 chunks +0 lines, -18 lines 0 comments Download
M chrome/app/generated_resources.grd View 5 chunks +0 lines, -42 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-13 22:35:23 UTC) #1
stuartmorgan
lgtm
6 years, 7 months ago (2014-05-13 22:37:44 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-13 22:49:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/274863004/20001
6 years, 7 months ago (2014-05-13 22:56:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 23:43:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 23:48:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/4014) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/67513) linux_chromium_chromeos_rel ...
6 years, 7 months ago (2014-05-13 23:48:09 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-14 00:01:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/274863004/40001
6 years, 7 months ago (2014-05-14 00:03:16 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 03:08:11 UTC) #10
Message was sent while issue was closed.
Change committed as 270316

Powered by Google App Engine
This is Rietveld 408576698