Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2748623003: Adding test (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adding test Add script to update relevant changes to Node.js. R=franzih@chromium.org, machenbach@chromium.org, ofrobots@google.com patch from issue 2744663005 at patchset 40001 (http://crrev.com/2744663005#ps40001) BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -0 lines) Patch
A tools/release/testdata/gtest/baz/gtest_foo View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/gtest/baz/gtest_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/gtest/gtest_bar View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/gtest/gtest_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/gtest/new/gtest_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/node/deps/v8/.gitignore View 1 chunk +7 lines, -0 lines 0 comments Download
A tools/release/testdata/node/deps/v8/baz/delete_me View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/node/deps/v8/baz/v8_foo View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/node/deps/v8/delete_me View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/node/deps/v8/v8_foo View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/.gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/release/testdata/v8/baz/v8_foo View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/baz/v8_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/new/v8_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/testing/dummy View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/v8_foo View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/testdata/v8/v8_new View 1 chunk +1 line, -0 lines 0 comments Download
A tools/release/update_node.py View 1 chunk +108 lines, -0 lines 0 comments Download
A tools/release/update_node_test.py View 1 chunk +93 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Franzi
LGTM. Should we add a comment to the script that any changes should be reflected ...
3 years, 9 months ago (2017-03-14 10:02:43 UTC) #1
Michael Achenbach
On 2017/03/14 10:02:43, Franzi wrote: > LGTM. Should we add a comment to the script ...
3 years, 9 months ago (2017-03-14 10:09:48 UTC) #2
Michael Achenbach
3 years, 9 months ago (2017-03-14 10:11:40 UTC) #3
Message was sent while issue was closed. 
Filed http://crbug.com/701296

Powered by Google App Engine
This is Rietveld 408576698