Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/core/frame/FrameLifecycle.cpp

Issue 2748603002: Add a lifecycle state machine for Page (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameLifecycle.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameLifecycle.cpp b/third_party/WebKit/Source/core/frame/FrameLifecycle.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..77b977e7cab40f41120eac14ff64fc263946e61c
--- /dev/null
+++ b/third_party/WebKit/Source/core/frame/FrameLifecycle.cpp
@@ -0,0 +1,29 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/frame/FrameLifecycle.h"
+
+#include "wtf/Assertions.h"
+
+namespace blink {
+
+FrameLifecycle::FrameLifecycle() : m_state(Attached) {}
+
+void FrameLifecycle::advanceTo(State state) {
+ switch (state) {
+ case Attached:
+ case Detached:
+ // Normally, only allow state to move forward.
+ DCHECK_GT(state, m_state);
+ break;
+ case Detaching:
+ // We can go from Detaching to Detaching since the detach() method can be
+ // re-entered.
+ DCHECK_GE(state, m_state);
+ break;
+ }
+ m_state = state;
+}
+
+} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameLifecycle.h ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698