Cleanup of page_measurement_results object

tools/telemetry/telemetry/value/scalar_unittest.py

Index: tools/telemetry/telemetry/value/scalar_unittest.py
diff --git a/tools/telemetry/telemetry/value/scalar_unittest.py b/tools/telemetry/telemetry/value/scalar_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..1f41a68a562fafe7372cc2fed29d88efcc2eadcd
--- /dev/null
+++ b/tools/telemetry/telemetry/value/scalar_unittest.py
@@ -0,0 +1,66 @@
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+import os
+import unittest
+
+from telemetry import value
+from telemetry.page import page_set
+from telemetry.value.scalar import ScalarValue
+
+class TestBase(unittest.TestCase):
+  def setUp(self):
+    self.page_set =  page_set.PageSet.FromDict({
+      "description": "hello",
+      "archive_path": "foo.wpr",
+      "pages": [
+        {"url": "http://www.bar.com/"},
+        {"url": "http://www.baz.com/"},
+        {"url": "http://www.foo.com/"}
+        ]
+      }, os.path.dirname(__file__))
+
+  @property
+  def pages(self):
+    return self.page_set.pages
+
+class ValueTest(TestBase):
+  def testBuildbotValueType(self):
+    page0 = self.pages[0]
+    v = ScalarValue(page0, 'x', 'unit', 3, important=True)
+    self.assertEquals('default', v.GetBuildbotDataType(
+        value.MERGED_PAGES_RESULT_OUTPUT_CONTEXT))
+    self.assertEquals([3], v.GetBuildbotValue())
+    self.assertEquals(('x_by_url', page0.display_name),
+                      v.GetBuildbotMeasurementAndTraceNameForPerPageResult())
+
+    v = ScalarValue(page0, 'x', 'unit', 3, important=False)
+    self.assertEquals(
+        'unimportant',
+        v.GetBuildbotDataType(value.MERGED_PAGES_RESULT_OUTPUT_CONTEXT))
+
+  def testScalarSamePageMerging(self):
+    page0 = self.pages[0]
+    v0 = ScalarValue(page0, 'x', 'unit', 1)
+    v1 = ScalarValue(page0, 'x', 'unit', 2)
+    self.assertTrue(v1.IsMergableWith(v0))
+
+    vM = ScalarValue.MergeLikeValuesFromSamePage([v0, v1])
+    self.assertEquals(page0, vM.page)
+    self.assertEquals('x', vM.name)
+    self.assertEquals('unit', vM.units)
+    self.assertEquals(True, vM.important)
+    self.assertEquals([1, 2], vM.values)
+
+  def testScalarDifferentSiteMerging(self):
+    page0 = self.pages[0]
+    page1 = self.pages[1]
+    v0 = ScalarValue(page0, 'x', 'unit', 1)
+    v1 = ScalarValue(page1, 'x', 'unit', 2)
+
+    vM = ScalarValue.MergeLikeValuesFromDifferentPages([v0, v1])
+    self.assertEquals(None, vM.page)
+    self.assertEquals('x', vM.name)
+    self.assertEquals('unit', vM.units)
+    self.assertEquals(True, vM.important)
+    self.assertEquals([1, 2], vM.values)