Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: tools/telemetry/telemetry/page/page_test_results.py

Issue 27486002: Cleanup of page_measurement_results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: keep on trying Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_test_results.py
diff --git a/tools/telemetry/telemetry/page/page_test_results.py b/tools/telemetry/telemetry/page/page_test_results.py
index 20d314b6d64a78f7531378787e46ef9139c74d18..8c763fc7125aa0e68a059d548be446503c807072 100644
--- a/tools/telemetry/telemetry/page/page_test_results.py
+++ b/tools/telemetry/telemetry/page/page_test_results.py
@@ -10,9 +10,16 @@ import unittest
class PageTestResults(unittest.TestResult):
def __init__(self):
super(PageTestResults, self).__init__()
+ self.pages_that_had_errors = set()
+ self.pages_that_had_failures = set()
self.successes = []
self.skipped = []
+ @property
+ def pages_that_had_errors_or_failures(self):
+ return self.pages_that_had_errors.union(
+ self.pages_that_had_failures)
+
def _exc_info_to_string(self, err, test):
if isinstance(test, unittest.TestCase):
return super(PageTestResults, self)._exc_info_to_string(err, test)
@@ -32,9 +39,11 @@ class PageTestResults(unittest.TestResult):
self.stopTest(page.display_name)
def AddError(self, page, err):
+ self.pages_that_had_errors.add(page)
self.addError(page.display_name, err)
def AddFailure(self, page, err):
+ self.pages_that_had_failures.add(page)
self.addFailure(page.display_name, err)
def AddSuccess(self, page):
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_value.py ('k') | tools/telemetry/telemetry/page/page_test_results_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698