tools/telemetry/telemetry/page/page_measurement_unittest.py - Issue 27486002: Cleanup of page_measurement_results object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest.py

Issue 27486002: Cleanup of page_measurement_results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: keep on trying Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest.py b/tools/telemetry/telemetry/page/page_measurement_unittest.py

index 49d434bfa14f5c0b436a64d7b7e3a2fd69794b98..32282636119e0a33e44bb8ea0d2c16499d0826c2 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest.py

@@ -81,9 +81,9 @@ class PageMeasurementUnitTest(

ps = self.CreatePageSetFromFileInUnittestDataDir('blank.html')

measurement = MeasurementThatHasDefaults()

all_results = self.RunMeasurement(measurement, ps, options=self._options)

- self.assertEquals(len(all_results.page_results), 1)

+ self.assertEquals(len(all_results.all_page_specific_values), 1)

self.assertEquals(

- all_results.page_results[0].FindValueByTraceName('x').value, 7)

+ all_results.all_page_specific_values[0].value, 7)

def disabled_testRecordAndReplay(self):

# This test is disabled because it runs against live sites, and needs to be