Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

Issue 27486002: Cleanup of page_measurement_results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: keep on trying Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
index dbae9507b6dea3266267ab5a093d2e503534f491..e7412d44d1035d8a648d13fffc416248979ae0e4 100644
--- a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
@@ -52,21 +52,21 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
results.Add('foo', 'seconds', 3)
results.DidMeasurePage()
self.assertEquals(
- self.output_header_row,
- ['page_name', 'foo (seconds)'])
+ self.output_header_row,
+ ['page_name', 'foo (seconds)'])
self.assertEquals(
- self.output_data_rows[0],
- [self._page_set[0].url, '3'])
+ self.output_data_rows[0],
+ [self._page_set[0].url, '3'])
results.WillMeasurePage(self._page_set[1])
results.Add('foo', 'seconds', 4)
results.DidMeasurePage()
self.assertEquals(
- len(self.output_data_rows),
- 2)
+ len(self.output_data_rows),
+ 2)
self.assertEquals(
- self.output_data_rows[1],
- [self._page_set[1].url, '4'])
+ self.output_data_rows[1],
+ [self._page_set[1].url, '4'])
def test_with_output_after_every_page_and_inconsistency(self):
results = NonPrintingCsvPageMeasurementResults(self._output, True)
@@ -97,10 +97,10 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
self.assertEquals(
self.output_header_row,
['page_name', 'bar (seconds)', 'foo (seconds)'])
- self.assertEquals(
- self.output_data_rows,
- [[self._page_set[0].display_name, '-', '3'],
- [self._page_set[1].display_name, '4', '-']])
+
+ expected = [[self._page_set[0].display_name, '-', '3.0'],
+ [self._page_set[1].display_name, '4.0', '-']]
+ self.assertEquals(expected, self.output_data_rows)
def test_histogram(self):
results = NonPrintingCsvPageMeasurementResults(self._output, False)
@@ -119,9 +119,9 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
results.PrintSummary()
self.assertEquals(
- self.output_header_row,
- ['page_name', 'a ()'])
+ self.output_header_row,
+ ['page_name', 'a ()'])
self.assertEquals(
- self.output_data_rows,
- [[self._page_set[0].display_name, '1.5'],
- [self._page_set[1].display_name, '2.5']])
+ self.output_data_rows,
+ [[self._page_set[0].display_name, '1.5'],
+ [self._page_set[1].display_name, '2.5']])

Powered by Google App Engine
This is Rietveld 408576698