Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: tools/telemetry/telemetry/page/block_page_measurement_results.py

Issue 27486002: Cleanup of page_measurement_results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: keep on trying Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/block_page_measurement_results.py
diff --git a/tools/telemetry/telemetry/page/block_page_measurement_results.py b/tools/telemetry/telemetry/page/block_page_measurement_results.py
index fd720e39c48ff92e9cb6af2eae22983f114972e1..a3f0972770d2b8ed62e9eb72ecc5850b02cfbdf1 100644
--- a/tools/telemetry/telemetry/page/block_page_measurement_results.py
+++ b/tools/telemetry/telemetry/page/block_page_measurement_results.py
@@ -12,24 +12,19 @@ class BlockPageMeasurementResults(
self._output_file = output_file
def DidMeasurePage(self):
- page_values = self.values_for_current_page
-
- if not page_values.values:
+ values = self.page_specific_values_for_current_page
+ if not values:
# Do not output if no results were added on this page.
super(BlockPageMeasurementResults, self).DidMeasurePage()
return
-
lines = ['name: %s' %
- self.values_for_current_page.page.display_name]
- sorted_measurement_names = page_values.measurement_names
- sorted_measurement_names.sort()
+ values[0].page.display_name]
- for measurement_name in sorted_measurement_names:
- value = page_values.FindValueByMeasurementName(measurement_name)
+ for value in sorted(values, key=lambda x: x.name):
lines.append('%s (%s): %s' %
- (measurement_name,
+ (value.name,
value.units,
- value.output_value))
+ value.GetRepresentativeString()))
for line in lines:
self._output_file.write(line)
self._output_file.write(os.linesep)
« no previous file with comments | « tools/perf/metrics/smoothness_unittest.py ('k') | tools/telemetry/telemetry/page/buildbot_page_measurement_results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698