Cleanup of page_measurement_results object

tools/telemetry/telemetry/page/block_page_measurement_results.py

Index: tools/telemetry/telemetry/page/block_page_measurement_results.py
diff --git a/tools/telemetry/telemetry/page/block_page_measurement_results.py b/tools/telemetry/telemetry/page/block_page_measurement_results.py
index fd720e39c48ff92e9cb6af2eae22983f114972e1..3b11eede7fc150667f853353b8326dd1fa293bdf 100644
--- a/tools/telemetry/telemetry/page/block_page_measurement_results.py
+++ b/tools/telemetry/telemetry/page/block_page_measurement_results.py
@@ -12,24 +12,24 @@ class BlockPageMeasurementResults(
     self._output_file = output_file
 
   def DidMeasurePage(self):
-    page_values = self.values_for_current_page
-
-    if not page_values.values:
+    values = self.page_specific_values_for_current_page
+    if len(values) == 0:

[tonyg, 2013/11/04 20:15:04]

if not values:

       # Do not output if no results were added on this page.
       super(BlockPageMeasurementResults, self).DidMeasurePage()
       return
-
     lines = ['name: %s' %
-             self.values_for_current_page.page.display_name]
-    sorted_measurement_names = page_values.measurement_names
-    sorted_measurement_names.sort()
+             values[0].page.display_name]
+
+    values_by_value_name = {}

[dtu, 2013/11/01 00:16:31]

You're doing this same value sorting operation in multiple places. Maybe write a
helper function to do it, or maybe PageMeasurementResults should take care of
maintaining or returning a sorted Value list.

Additionally, this could just be:

for value in sorted(values, key=lambda value: value.name):
  lines.append

+    for value in values:
+      values_by_value_name[value.name] = value
 
-    for measurement_name in sorted_measurement_names:
-      value = page_values.FindValueByMeasurementName(measurement_name)
+    for value_name in sorted(values_by_value_name.iterkeys()):
+      value = values_by_value_name[value_name]
       lines.append('%s (%s): %s' %
-                 (measurement_name,
+                 (value_name,
                   value.units,
-                  value.output_value))
+                  value.GetRepresentativeStringValue()))
     for line in lines:
       self._output_file.write(line)
       self._output_file.write(os.linesep)