Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: tools/perf/measurements/page_cycler_unittest.py

Issue 27486002: Cleanup of page_measurement_results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: keep on trying Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/perf/benchmarks/peacekeeper.py ('k') | tools/perf/metrics/smoothness_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import unittest 4 import unittest
5 5
6 from measurements import page_cycler 6 from measurements import page_cycler
7 from telemetry.core import browser_options 7 from telemetry.core import browser_options
8 from telemetry.page import page_measurement_results 8 from telemetry.page import page_measurement_results
9 from telemetry.unittest import simple_mock 9 from telemetry.unittest import simple_mock
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 url_name = "http://fakepage.com" 113 url_name = "http://fakepage.com"
114 page = FakePage(url_name) 114 page = FakePage(url_name)
115 tab = FakeTab() 115 tab = FakeTab()
116 results = page_measurement_results.PageMeasurementResults() 116 results = page_measurement_results.PageMeasurementResults()
117 117
118 for i in range(5): 118 for i in range(5):
119 cycler.WillNavigateToPage(page, tab) 119 cycler.WillNavigateToPage(page, tab)
120 self.assertEqual(max(0, i - 2), tab.clear_cache_calls, 120 self.assertEqual(max(0, i - 2), tab.clear_cache_calls,
121 "Iteration %d tab.clear_cache_calls %d" % 121 "Iteration %d tab.clear_cache_calls %d" %
122 (i, tab.clear_cache_calls)) 122 (i, tab.clear_cache_calls))
123 num_results = len(results.page_results)
124 results.WillMeasurePage(page) 123 results.WillMeasurePage(page)
125 cycler.MeasurePage(page, tab, results) 124 cycler.MeasurePage(page, tab, results)
125
126 values = results.page_specific_values_for_current_page
126 results.DidMeasurePage() 127 results.DidMeasurePage()
127 self.assertEqual(num_results+1, len(results.page_results)) 128
128 result = results[-1] 129 self.assertEqual(1, len(values))
129 self.assertEqual(result.page, page) 130 self.assertEqual(values[0].page, page)
130 self.assertEqual(1, len(result.values)) 131
131 self.assertEqual(result.values[0].trace_name, 'page_load_time') 132 chart_name = 'warm_times' if i > 3 else 'cold_times'
132 self.assertEqual(result.values[0].units, 'ms') 133 print values[0].name
133 self.assertEqual(result.values[0].chart_name, 134 self.assertEqual(values[0].name, '%s.page_load_time' % chart_name)
134 'warm_times' if i < 3 else 'cold_times') 135 self.assertEqual(values[0].units, 'ms')
136
135 cycler.DidNavigateToPage(page, tab) 137 cycler.DidNavigateToPage(page, tab)
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/peacekeeper.py ('k') | tools/perf/metrics/smoothness_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698