Identity API: add chrome.identity.getAccounts

Identity API: add chrome.identity.getAccounts

This new API returns a list of accounts signed in to the profile. The
first element of the list is always the primary account. Other accounts
are returned after, sorted by obfuscated gaia ID.

The API is currently available in dev channel. If the flag
--extensions-multi-account (or --new-profile-management) is enabled,
getAccounts will return all accounts. Otherwise only the primary account
is returned.

BUG=258515
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270325

[Michael Courage, 2014-05-13 01:15:03]

fgorski:
  chrome/browser/extensions/api/identity/*
rogerta:
  components/signin/core/common/profile_management_switches.cc
  components/signin/core/common/profile_management_switches.h
  components/signin/core/common/signin_switches.cc
  components/signin/core/common/signin_switches.h
asvitkine:
  extensions/browser/extension_function_histogram_value.h
  tools/metrics/histograms/histograms.xml
kalman:
  chrome/common/extensions/api/_api_features.json
  chrome/common/extensions/api/identity.idl

[Roger Tawa OOO till Jul 10th, 2014-05-13 14:13:12]

lgtm

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_api.cc (right):

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_api.cc:258:
~IdentityGetAccountsFunction() {
nit: I don't think you need to wrap line.

https://codereview.chromium.org/274853002/diff/70001/components/signin/core/c...
File components/signin/core/common/signin_switches.cc (right):

https://codereview.chromium.org/274853002/diff/70001/components/signin/core/c...
components/signin/core/common/signin_switches.cc:15: const char
kEnableWebBasedSignin[]            = "enable-web-based-signin";
nit: not your change, but could you fix this alignment of this line?  On the
other hand, I'm not sure why we have multiple spaces between [] and =.  Remove
all extra spaces?

[fgorski, 2014-05-13 16:22:12]

lgtm

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/account_tracker_unittest.cc (right):

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/account_tracker_unittest.cc:295: // We
don't sign the primary user in and out on ChromeOS, so set up the
nit: drop the "up"... , so set the username once

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/account_tracker_unittest.cc:673:
EXPECT_EQ(1ul, ids.size());
nit: 1UL?

same for other xUL below.

[Alexei Svitkine (slow), 2014-05-13 16:57:16]

histograms lgtm

[Michael Courage, 2014-05-13 17:02:06]

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/account_tracker_unittest.cc (right):

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/account_tracker_unittest.cc:295: // We
don't sign the primary user in and out on ChromeOS, so set up the
On 2014/05/13 16:22:12, fgorski wrote:
> nit: drop the "up"... , so set the username once

Done.

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/account_tracker_unittest.cc:673:
EXPECT_EQ(1ul, ids.size());
On 2014/05/13 16:22:12, fgorski wrote:
> nit: 1UL?
> 
> same for other xUL below.

Any particular reason to do so? I don't see any mention of the case for constant
suffixes in the style-guide, and usage in Chromium appears mixed. Existing tests
are using lower case.

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
File chrome/browser/extensions/api/identity/identity_api.cc (right):

https://codereview.chromium.org/274853002/diff/70001/chrome/browser/extension...
chrome/browser/extensions/api/identity/identity_api.cc:258:
~IdentityGetAccountsFunction() {
On 2014/05/13 14:13:12, Roger Tawa wrote:
> nit: I don't think you need to wrap line.

Done. clang-formatted the whole class definition.

https://codereview.chromium.org/274853002/diff/70001/components/signin/core/c...
File components/signin/core/common/signin_switches.cc (right):

https://codereview.chromium.org/274853002/diff/70001/components/signin/core/c...
components/signin/core/common/signin_switches.cc:15: const char
kEnableWebBasedSignin[]            = "enable-web-based-signin";
On 2014/05/13 14:13:12, Roger Tawa wrote:
> nit: not your change, but could you fix this alignment of this line?  On the
> other hand, I'm not sure why we have multiple spaces between [] and =.  Remove
> all extra spaces?

Done.

[not at google - send to devlin, 2014-05-13 19:29:11]

schema lgtm. IIRC we reviewed this API aaaages ago?

[Michael Courage, 2014-05-13 19:52:26]

On 2014/05/13 19:29:11, kalman wrote:
> schema lgtm. IIRC we reviewed this API aaaages ago?

indeed that aged document referenced in http://crbug.com/226203 bears the lgtm
of the Ancient Reviewers of 2013

[Michael Courage, 2014-05-13 21:50:43]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-05-13 22:05:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/274853002/30002

[commit-bot: I haz the power, 2014-05-13 22:50:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Michael Courage, 2014-05-13 22:54:03]

The CQ bit was checked by courage@chromium.org

[commit-bot: I haz the power, 2014-05-13 23:06:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/courage@chromium.org/274853002/90001

[commit-bot: I haz the power, 2014-05-14 03:55:28]

Change committed as 270325